Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves the logic that handles the registration for serialization of OpenAPI schema class to smallrye-openapi-extension #1529

Conversation

machi1990
Copy link
Member

@machi1990 machi1990 commented Mar 15, 2019

After merging of 1389, @kenfinnigan came with a better idea of moving the said logic from resteasy-extension into smallrye-openapi-extension. This PR incorporates the proposed changes.

cc @gsmet.

@machi1990 machi1990 force-pushed the refacto/move-openapi-schema-in-smallrye-openapi-extension branch from 7c0d65a to af84073 Compare March 15, 2019 23:14
@gsmet
Copy link
Member

gsmet commented Mar 15, 2019

There is a formatting issue: run mvn formatter:format in the openapi extension directory: that will fix it.

@machi1990
Copy link
Member Author

There is a formatting issue: run mvn formatter:format in the openapi extension directory: that will fix it.

Thanks, I'll be running the command onwards. My IDE is still giving me some headache with the formatting ide-config.

@machi1990 machi1990 force-pushed the refacto/move-openapi-schema-in-smallrye-openapi-extension branch from af84073 to 46172c2 Compare March 15, 2019 23:20
@gsmet
Copy link
Member

gsmet commented Mar 15, 2019

The easy way to get everything in order is to run mvn clean install before pushing any PR. It runs the test suite but it also reformat everything.

@machi1990
Copy link
Member Author

The easy way to get everything in order is to run mvn clean install before pushing any PR. It runs the test suite but it also reformat everything.

Golden rule :-)

@machi1990 machi1990 marked this pull request as ready for review March 15, 2019 23:34
@machi1990 machi1990 force-pushed the refacto/move-openapi-schema-in-smallrye-openapi-extension branch 2 times, most recently from 844ad09 to bf8dc12 Compare March 16, 2019 12:17
@machi1990 machi1990 force-pushed the refacto/move-openapi-schema-in-smallrye-openapi-extension branch from bf8dc12 to 28dd2ae Compare March 16, 2019 13:01
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, thanks!

@gsmet gsmet merged commit 20f01d1 into quarkusio:master Mar 16, 2019
@gsmet gsmet added this to the 0.12.0 milestone Mar 16, 2019
@machi1990 machi1990 deleted the refacto/move-openapi-schema-in-smallrye-openapi-extension branch March 16, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants