Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc is able to build without depending on JBoss Nexus #1510

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Mar 15, 2019

No description provided.

@Sanne Sanne requested a review from mkouba March 15, 2019 11:59
@gsmet
Copy link
Member

gsmet commented Mar 15, 2019

@Sanne I'm not totally sure about that. IIRC, we had an issue with Quarkus due to a MR jar of jboss-parent not pushed to Maven Central. I'm not sure it affects Arc though but we should check. Did you try to build it in a clean room? (And, sure, these jars should be pushed to Central...)

@Sanne
Copy link
Member Author

Sanne commented Mar 15, 2019

yes I'm testing to build everything in "clean room".

Other modules are still problematic, but this one is fine. So I'd like to change this so to make sure we won't go backwards.

The jboss-parent actually reconfigures the build to download plugin dependencies from JBoss Nexus; that's active even if we remove this - and at least it limits itself to maven plugins.

@gsmet gsmet merged commit 8e7c2a4 into quarkusio:master Mar 15, 2019
@Sanne Sanne deleted the NexusLessArc branch March 15, 2019 16:59
@gsmet gsmet added this to the 0.12.0 milestone Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants