-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added gradle-tooling doc. splitted up the tooling into maven/gradle/cli #1194
Conversation
i decided to split out the maven tooling into a separate document. users interested in maven are not interested in gradle and vice versa. - but if others disagree im fine with trying to weave it all into one doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I think I preferred a single tooling doc but it would have made for a verbose solution.
The main problem is the missing CLI adoc file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stalep I added additional comments.
Please ping me when you applied the changes and added the CLI guide. I will review it again.
So based on our discussions last week and just now (including with @emmanuelbernard ), we have a bunch of usability work with tool that we are out of time to do (e.g. how do you get the tool, does it install maven since you can't use the project without maven, etc). We can skip the CLI section for now. and merge without it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stalep even if we don't include the CLI guide tomorrow, I added a few comments. I think the most important one is the s/MICRONAUT/QUARKUS/ one.
It would be nice if you could amend the commit so that it doesn't appear in the history.
i rebased it all into one commit, thanks again for the reviews @gsmet ! |
Changes look to be applied
No description provided.