Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shamrock:dev allows debug port 0 to be used #544

Closed
jeffmaury opened this issue Jan 16, 2019 · 0 comments
Closed

shamrock:dev allows debug port 0 to be used #544

jeffmaury opened this issue Jan 16, 2019 · 0 comments
Labels
kind/bug Something isn't working
Milestone
0.7.0

Comments

@jeffmaury
Copy link
Contributor

As the debug port can now be specified, the 0 value is allowed leading to wrong configuration as the allocated port is not retrieved
@cescoffier cescoffier added this to the 0.7.0 milestone Jan 17, 2019
@cescoffier cescoffier added the kind/bug Something isn't working label Jan 17, 2019
stuartwdouglas added a commit that referenced this issue Jan 17, 2019
@stuartwdouglas
Merge pull request #547 from cescoffier/features/ensure-debug-port-is…
9918eaf 
…-positive

Fix #544 - ensure the debug port is positive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@cescoffier @jeffmaury