Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom jakarta.ws.rs.ext.RuntimeDelegate via configuration #44301

Closed
kpagratis opened this issue Nov 4, 2024 · 4 comments
Closed

allow custom jakarta.ws.rs.ext.RuntimeDelegate via configuration #44301

kpagratis opened this issue Nov 4, 2024 · 4 comments
Labels
area/rest kind/enhancement New feature or request

Comments

@kpagratis
Copy link

Description

We have a requirement where we need to use our own jakarta.ws.rs.core.UriBuilder when using quarkus REST.
We originally registered our implementation via the java service loader and this work in dev mode but stoped working in prod mode.
We got around this issue by calling jakarta.ws.rs.ext.RuntimeDelegate::setInstance in a startup method. It would be great if there was a configuration that could be set to defind the RuntimeDelgate to use. If this optional field is missing, then the default jboss delegate can be chosen.

Implementation ideas

The runtime delegate is defined in the ResteasyReactiveCommonProvessor class on line 342 on tag 3.16.
It seems like this could be executed conditionally based on a configuration value.

@kpagratis kpagratis added the kind/enhancement New feature or request label Nov 4, 2024
Copy link

quarkus-bot bot commented Nov 4, 2024

/cc @radcortez (config)

@geoand
Copy link
Contributor

geoand commented Nov 6, 2024

Thanks for reporting!

Mind providing a sample application that shows what you were doing and stopped working?

In an case, #44335 should take care of the problem for native

@geoand geoand closed this as completed in 4af3754 Nov 6, 2024
geoand added a commit that referenced this issue Nov 6, 2024
Allow for using RuntimeDelegate SPI in native mode
@kpagratis
Copy link
Author

Sure I can cobble something together. Are you saying #44335 fixes the problem?

I had created a META-INF/services/jakarta.ws.rs.ext.RuntimeDelegate where the first line was my delegate com.example.MyRuntimeDelegate and this worked in devmode but not in prod mode (quarkusRun)
I can try again if you let me know how to test with 44335

@geoand
Copy link
Contributor

geoand commented Nov 6, 2024

If it doesn't work, I certainly want to see what's going 🙂

gsmet pushed a commit to gsmet/quarkus that referenced this issue Nov 12, 2024
bschuhmann pushed a commit to bschuhmann/quarkus that referenced this issue Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants