Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Native tests don't run due to failsafe <skip>true</skip> #43997

Closed
Karm opened this issue Oct 21, 2024 · 3 comments · Fixed by #44139
Closed

Some Native tests don't run due to failsafe <skip>true</skip> #43997

Karm opened this issue Oct 21, 2024 · 3 comments · Fixed by #44139
Assignees
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/native-image
Milestone

Comments

@Karm
Copy link
Member

Karm commented Oct 21, 2024

Description

While reviewing #43829 I noticed the GHA has been giving us false negative, not running awt integration test.

When I tried locally, I wasn't able to make maven run the awt testsuite with native-image either. The harness runs HotSpot tests, then it builds the native-image but it doesn't run any tests with it.

./mvnw verify -f integration-tests/pom.xml -pl awt  -Pnative

I did try to fiddle with various maven flags like -DskipITs=false to no avail.

Trying to run the test in container had a similar result, the harness executed HotSpot tests, it went on to build the native executable using builder-image, then it built a runtime container image and copied the executable in it, then it started the runtime container and terminated there, not executing any actual tests.

./mvnw verify -f integration-tests/pom.xml -pl awt -Ddocker -Pnative -Dquarkus.native.container-build=true -Dquarkus.container-image.build=true -Dquarkus.native.builder-image=quay.io/quarkus/ubi-quarkus-mandrel-builder-image:jdk-21 -Dquarkus.native.container-runtime=podman -DskipITs=false 2>&1 | tee log.log

I had to manually patch the pom.xml to make it run the testsuite properly:

tester@mandrel2:~/karm/quarkus (2024-10-11-awt-processor-refactor *%=)$ git diff
diff --git a/integration-tests/awt/pom.xml b/integration-tests/awt/pom.xml
index f71302da2c2..eb290a5e037 100644
--- a/integration-tests/awt/pom.xml
+++ b/integration-tests/awt/pom.xml
@@ -164,7 +164,7 @@
             <plugin>
                 <artifactId>maven-failsafe-plugin</artifactId>
                 <configuration>
-                    <skip>true</skip>
+                    <skip>false</skip>
                 </configuration>
             </plugin>
         </plugins>

It seems that this is the change that has brought the skip>true</skip> in: 9f3ba1922d2

Question

  • Isn't there any Maven flag missing from our GHA yaml? Which is it and how it was meant to be executed?
  • Aren't there many more native-image integration tests affected? Merely building the executables but silently not running any tests? A casual find && grep tells me that it might be the case.

Thx
K.

Implementation ideas

No response

@Karm Karm added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Oct 21, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 21, 2024

/cc @galderz (mandrel), @zakkak (mandrel,native-image)

@gsmet
Copy link
Member

gsmet commented Oct 28, 2024

Having a look at this one.

gsmet added a commit to gsmet/quarkus that referenced this issue Oct 28, 2024
The plugin shouldn't be defined and disabled, it will be automatically
enabled by the profile.

Fixes quarkusio#43997
@gsmet
Copy link
Member

gsmet commented Oct 28, 2024

I fixed the AWT case here: #44139 .

Not sure if there are other cases though as for instance in the Redis case integration-tests/redis-client, it's expected that we disable Failsafe by default, it's enabled when you enable the container build.

If you have specific examples that look suspicious to you, please point them to me and I'll have a look. In the meantime, AWT testing should be fine after the PR. Sorry for the oversight!

@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 29, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.1 Oct 29, 2024
gsmet added a commit to gsmet/quarkus that referenced this issue Oct 29, 2024
The plugin shouldn't be defined and disabled, it will be automatically
enabled by the profile.

Fixes quarkusio#43997

(cherry picked from commit a349b01)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/native-image
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants