-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rest: shorten the names of the generated classes #43786
Comments
You added a link to a Zulip discussion, please make sure the description of the issue is comprehensive and doesn't require accessing Zulip This message is automatically generated by a bot. |
Any good solution outside computing a hash of the name? |
A computed hash is fine IMO. |
Hashes work but make debugging harder and logger names useless. But if that's the only solution, we must live with it. |
Well, I don't think we use loggers in these generated classes. As for the debugging - the base class is usually good enough to find out where to start. In case of the example above - |
/cc @FroMage (rest), @stuartwdouglas (rest) |
besides devui would these not show up in stacktraces too? all for not too long names but shouldn't also just be a hashid as name brings meaning :) |
If we can keep the meaningful part and append a hash, it would provide a good experience. |
#44418 would make the name something like: |
Simplify name of generated exception mappers
Description
There seems to be no reason for the names to be so looong.
For example
io.quarkus.resteasy.reactive.server.runtime.exceptionmappers.AuthenticationFailedExceptionMapper$GeneratedExceptionHandlerFor$AuthenticationFailedException$OfMethod$handle
. The simple name has 111 chars in this particular case.The
ArC > Beans
view in the Dev UI does not look good. Also every call site of this class must store this name in the constant pool ;-).Zulip discussion: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Loooong.20names.20of.20generated.20classes.20in.20resteasy-reactive
Implementation ideas
No response
The text was updated successfully, but these errors were encountered: