Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate or remove io.quarkus.test.common.DefineClassVisibleClassLoader #43730

Closed
dmlloyd opened this issue Oct 5, 2024 · 1 comment · Fixed by #44138
Closed

Deprecate or remove io.quarkus.test.common.DefineClassVisibleClassLoader #43730

dmlloyd opened this issue Oct 5, 2024 · 1 comment · Fixed by #44138
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone
3.17.0.CR1

Comments

@dmlloyd
Copy link
Member

dmlloyd commented Oct 5, 2024

Description

The io.quarkus.test.common.DefineClassVisibleClassLoader class should not be used. If a class has to be defined for a test, normally Lookup.defineClass would be the appropriate thing to use.

There appears to be no usages of this class at this time.

/cc @geoand

Implementation ideas

No response
@dmlloyd dmlloyd added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Oct 5, 2024
@geoand
Copy link
Contributor

geoand commented Oct 5, 2024

I don't even remember why this was added, but it was probably for some old reason that no longer applies

@dmlloyd dmlloyd mentioned this issue Oct 7, 2024
Closed
dmlloyd added a commit to dmlloyd/quarkus that referenced this issue Oct 28, 2024
@dmlloyd
Remove unused DefineClassVisibleClassLoader
5142eb6 
Fixes quarkusio#43730
@dmlloyd dmlloyd mentioned this issue Oct 28, 2024
Merged
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 29, 2024
bschuhmann pushed a commit to bschuhmann/quarkus that referenced this issue Nov 16, 2024
@dmlloyd @bschuhmann
Remove unused DefineClassVisibleClassLoader
2c7e106 
Fixes quarkusio#43730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Milestone
3.17.0.CR1
Development

Successfully merging a pull request may close this issue.

Remove unused DefineClassVisibleClassLoader dmlloyd/quarkus
2 participants
@dmlloyd @geoand