-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't cache m2 repo in GitHub Actions for PRs and take advantage of saved space #43559
Labels
area/housekeeping
Issue type for generalized tasks not related to bugs or enhancements
area/infra
internal and infrastructure related issues
Comments
yrodiere
added
the
area/housekeeping
Issue type for generalized tasks not related to bugs or enhancements
label
Sep 27, 2024
/cc @gwenneg (cache) |
You added a link to a Zulip discussion, please make sure the description of the issue is comprehensive and doesn't require accessing Zulip This message is automatically generated by a bot. |
yrodiere
added
area/infra
internal and infrastructure related issues
and removed
area/cache
labels
Sep 27, 2024
Sorry for the ping: the bot is wrong, this is not related to |
gsmet
added a commit
to gsmet/quarkus
that referenced
this issue
Sep 27, 2024
We use the ones coming from the push events. Related to quarkusio#43559
gsmet
added a commit
to gsmet/quarkus
that referenced
this issue
Sep 27, 2024
This can be useful when pushing small iterations to a pull request. It is limited to pull requests only and only for the Initial JDK build. We will check if it improves things and the size of the cache. Related to quarkusio#43559
gsmet
added a commit
to gsmet/quarkus
that referenced
this issue
Sep 27, 2024
This can be useful when pushing small iterations to a pull request. It is limited to pull requests only and only for the Initial JDK build. We will check if it improves things and the size of the cache. Related to quarkusio#43559
gsmet
added a commit
to gsmet/quarkus
that referenced
this issue
Sep 28, 2024
This can be useful when pushing small iterations to a pull request. It is limited to pull requests only and only for the Initial JDK build. We will check if it improves things and the size of the cache. Related to quarkusio#43559
gsmet
added a commit
to gsmet/quarkus
that referenced
this issue
Sep 30, 2024
We use the ones coming from the push events. Related to quarkusio#43559
gsmet
added a commit
to gsmet/quarkus
that referenced
this issue
Sep 30, 2024
This can be useful when pushing small iterations to a pull request. It is limited to pull requests only and only for the Initial JDK build. We will check if it improves things and the size of the cache. Related to quarkusio#43559
mskacelik
pushed a commit
to mskacelik/quarkus
that referenced
this issue
Oct 2, 2024
We use the ones coming from the push events. Related to quarkusio#43559
mskacelik
pushed a commit
to mskacelik/quarkus
that referenced
this issue
Oct 2, 2024
This can be useful when pushing small iterations to a pull request. It is limited to pull requests only and only for the Initial JDK build. We will check if it improves things and the size of the cache. Related to quarkusio#43559
gsmet
added a commit
to gsmet/quarkus
that referenced
this issue
Oct 21, 2024
We use the ones coming from the push events. Related to quarkusio#43559 (cherry picked from commit e788d0e)
gsmet
added a commit
to gsmet/quarkus
that referenced
this issue
Oct 21, 2024
This can be useful when pushing small iterations to a pull request. It is limited to pull requests only and only for the Initial JDK build. We will check if it improves things and the size of the cache. Related to quarkusio#43559 (cherry picked from commit 287ce49)
I think we are now in a much better state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/housekeeping
Issue type for generalized tasks not related to bugs or enhancements
area/infra
internal and infrastructure related issues
Description
We're currently using the GitHub Actions cache for very dubious things, especially on PRs:
Ideally we'd cache them, but it's 1 to 2GB per PR, which is not sustainable considering the global 10GB limit for all branches and PRs:
We should stop doing that, and take advantage of that saved space to cache other, more space-efficient things on PRs.
Implementation ideas
We should prevent cache writes for Maven dependencies / gradle setup on PRs.
There's a[EDIT: Wrong, it does something else]. We'd only write to the cache from branch builds, restricting ourselves to read on PRs (so PRs benefit from the main branch's cache). This would save several GBs from our current cache usage, between 2 and 4GB depending when you check (you can check here).lookup-only
option on the cache action that does just thatUsing that saved space, we should enable cache read/write for the Develocity local build cache on PRs. This hopefully would take less that 4GB, and could result in much faster PR builds/testing, especially for small, incremental pushes to PRs.
See https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Persistent.20Develocity.20build.20cache.20in.20PRs/near/435358207
The text was updated successfully, but these errors were encountered: