-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The WebSocket Dev UI widget does not connect for nested classes #43534
Comments
/cc @phillip-kruger (devui) |
Is this Quarkus Dev ui or langchain4j extension? |
Quarkus Dev UI. Basically, if you have a websocket endpoint declared as a static nested class, the generated id is incorrect because of the public class Application {
@WebSocket(path="/ws")
static class MyWebSocket {
@OnTextMessage
String echo(String s) { return s; }
}
} |
I believe that it's a WS Next Dev UI. Will take a look. |
The websocket works, it's just the dev ui that compute an invalid javascript it. |
(BTW, I'm using the nested class technique in presentation to have everything in one file) |
Yes, I mean the Dev UI part of the WS Next extension... |
This one-liner fix should help.. |
- fixes quarkusio#43534 (cherry picked from commit 03a514d)
Describe the bug
When you click on
connect
, nothing happens.The console says:
Uncaught SyntaxError: Failed to execute 'querySelector' on 'DocumentFragment': '#org_acme_QuarkusAiServiceScopes$MyWSEndpoint' is not a valid selector.
I believe it's because my web socket is a nested class.
Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: