-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improper defaults in KubernetesClientBuildConfig #43474
Labels
Milestone
Comments
/cc @geoand (kubernetes), @iocanel (kubernetes), @radcortez (config) |
metacosm
added a commit
to metacosm/quarkus
that referenced
this issue
Sep 24, 2024
Fixes quarkusio#43474 Signed-off-by: Chris Laprun <[email protected]>
This was referenced Sep 24, 2024
metacosm
added a commit
to quarkiverse/quarkus-operator-sdk
that referenced
this issue
Sep 24, 2024
This should be removed when the underlying issue is fixed. See quarkusio/quarkus#43474 Signed-off-by: Chris Laprun <[email protected]>
metacosm
added a commit
to quarkiverse/quarkus-operator-sdk
that referenced
this issue
Sep 25, 2024
This should be removed when the underlying issue is fixed. See quarkusio/quarkus#43474 Signed-off-by: Chris Laprun <[email protected]>
metacosm
added a commit
to metacosm/quarkus
that referenced
this issue
Sep 25, 2024
Fixes quarkusio#43474 Signed-off-by: Chris Laprun <[email protected]>
metacosm
added a commit
to quarkiverse/quarkus-operator-sdk
that referenced
this issue
Sep 25, 2024
This should be removed when the underlying issue is fixed. See quarkusio/quarkus#43474 Signed-off-by: Chris Laprun <[email protected]>
This would be a good candidate for backporting, imo. |
mskacelik
pushed a commit
to mskacelik/quarkus
that referenced
this issue
Sep 27, 2024
Fixes quarkusio#43474 Signed-off-by: Chris Laprun <[email protected]>
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Oct 21, 2024
Fixes quarkusio#43474 Signed-off-by: Chris Laprun <[email protected]> (cherry picked from commit 243b4d3)
2 tasks
bschuhmann
pushed a commit
to bschuhmann/quarkus
that referenced
this issue
Nov 16, 2024
Fixes quarkusio#43474 Signed-off-by: Chris Laprun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Not strictly a bug but rather an annoyance: the default values that are provided in
KubernetesClientBuildConfig
are not up-to-date which leads to behavioral changes between a default configured client and one that's injected by Quarkus.Expected behavior
The defaults should be consistent with what users would expect when they're not using Quarkus
Actual behavior
The defaults do not match the current implementation anymore.
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
From a maintenance perspective, providing such defaults opens the door to the current issue where defaults are not in synch. The implementation is already set up to inherit defaults from the implementation so we should use that instead.
The text was updated successfully, but these errors were encountered: