Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Accept Header in PreMatching filter isn't considered by MessageBodyWriter #40019

Closed
myroch opened this issue Apr 11, 2024 · 3 comments · Fixed by #40022
Closed

Changing Accept Header in PreMatching filter isn't considered by MessageBodyWriter #40019

myroch opened this issue Apr 11, 2024 · 3 comments · Fixed by #40022
Labels
area/rest kind/bug Something isn't working
Milestone

Comments

@myroch
Copy link

myroch commented Apr 11, 2024

Describe the bug

#38130 fixed just the routing, but not the rendering by MessageBodyWriters

Expected behavior

Accept Header set in the pre-matching request filter shall decide which MessageBodyWriter will be selected.

Actual behavior

Setting the Accept Header inside the pre-matching request filter doesn't affect which MessageBodyWriter is being selected.

How to Reproduce?

Output of uname -a or ver

No response

Output of java -version

java 17.0.9 2023-10-17 LTS

Quarkus version or git rev

3.9.3

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.9.6

Additional information

No response

@geoand
Copy link
Contributor

geoand commented Apr 11, 2024

Thanks for reporting.

#40022 fixes the issue

gastaldi added a commit that referenced this issue Apr 11, 2024
Take MediaType set in pre-match filter into account during serialization
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 11, 2024
@anchialas
Copy link

Wow that was quick, thank you! Can this fix also be backported to 3.8 LTS?

@geoand
Copy link
Contributor

geoand commented Apr 12, 2024

🙏.

We do plan to backport the fix to 3.8 during the next patch release

@gsmet gsmet modified the milestones: 3.10.0.CR1, 3.9.4 Apr 17, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 17, 2024
zZHorizonZz pushed a commit to zZHorizonZz/quarkus-grpc-transcode that referenced this issue Apr 24, 2024
@gsmet gsmet modified the milestones: 3.9.4, 3.8.5 May 15, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this issue May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants