Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn/error for missing quarkus-rest-client-reactive-jackson|jsonb|jaxb #35586

Closed
maxandersen opened this issue Aug 28, 2023 · 3 comments · Fixed by #35590
Closed

warn/error for missing quarkus-rest-client-reactive-jackson|jsonb|jaxb #35586

maxandersen opened this issue Aug 28, 2023 · 3 comments · Fixed by #35590
Assignees
Labels
area/jackson Issues related to Jackson (JSON library) area/jaxb area/rest-client kind/enhancement New feature or request
Milestone

Comments

@maxandersen
Copy link
Member

Description

when updating timeless app i noticed rest-client were not properly serializing.

Found https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0#rest-client that mentions that 3.3 needs to explicilty put quarkus-rest-client-reactive-jackson.

I assume this is NOT just for jackson but for any of the json serializer that is needed?

For server side I believe we print a warning/information when no serializer is found to give a hint. We should consider adding the same.

For quarkus update between 2.x to 3.x we should consider adding this or at least output info about it since we should be able to detect rest-client is a dependency and thus needs a matching serializer to work.

Implementation ideas

No response

@maxandersen maxandersen added the kind/enhancement New feature or request label Aug 28, 2023
@quarkus-bot quarkus-bot bot added area/jackson Issues related to Jackson (JSON library) area/jaxb area/rest-client labels Aug 28, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 28, 2023

/cc @Sgitario (jaxb,rest-client), @cescoffier (rest-client), @geoand (jackson,rest-client), @gsmet (jackson,jaxb)

@geoand
Copy link
Contributor

geoand commented Aug 28, 2023

For server side I believe we print a warning/information when no serializer is found to give a hint

Correct.

We should consider adding the same.

Definitely!

@geoand
Copy link
Contributor

geoand commented Aug 28, 2023

#35590 should take care of it

geoand added a commit that referenced this issue Aug 28, 2023
Warn about missing JSON extension when using REST Client
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jackson Issues related to Jackson (JSON library) area/jaxb area/rest-client kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants