Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include minimum/recommended JDK version in the platform stream descriptor #28497

Closed
gastaldi opened this issue Oct 11, 2022 · 7 comments · Fixed by #30290
Closed

Include minimum/recommended JDK version in the platform stream descriptor #28497

gastaldi opened this issue Oct 11, 2022 · 7 comments · Fixed by #30290
Assignees
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform area/registry Quarkus Extension Registry kind/enhancement New feature or request
Milestone

Comments

@gastaldi
Copy link
Contributor

gastaldi commented Oct 11, 2022

Description

From @rsvoboda:

RHBQ 2.7 has a support cycle for 6+6 months, soon we will have RHBQ 2.13 and Quarkus upstream will be 2.14 (maybe 2.15 CR1) when we release RHBQ 2.13.
Each stream can have its own specifics (e.g. default Java version) and we will have multiple streams running together for a longer time.

Implementation ideas

Include the minimum and recommended JDK version in the platform stream (extension catalog) descriptor

@gastaldi gastaldi added the kind/enhancement New feature or request label Oct 11, 2022
@gastaldi gastaldi added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/registry Quarkus Extension Registry and removed triage/needs-triage labels Oct 11, 2022
@gastaldi gastaldi added the area/platform Issues related to definition and interaction with Quarkus Platform label Oct 28, 2022
@ia3andy
Copy link
Contributor

ia3andy commented Nov 2, 2022

@gastaldi we need both minimum and recommended versions, why "or"?

@gastaldi
Copy link
Contributor Author

gastaldi commented Nov 2, 2022

@ia3andy when I created the issue I thought it would not be necessary, but now that you mention, I think both makes sense (eg. because GraalVM might not work with the latest JDK)

@ia3andy
Copy link
Contributor

ia3andy commented Jan 10, 2023

@gastaldi any update on this as it will need it to flow all the way down to the tooling?

@gastaldi
Copy link
Contributor Author

We'll need to include this in the stream metadata.
Now we need to decide if this needs to be added in the extension catalog JSON that is distributed in Maven central or in the quarkus-extension-catalog repo?

@aloubyansky any thoughts?

@aloubyansky
Copy link
Member

We don't deploy stream metadata as part of platform releases. It's true though that we could add a Java version preference directly to https://github.com/quarkusio/quarkus/blob/main/devtools/bom-descriptor-json/src/main/resources/catalog-overrides.json under metadata/project/properties for example. That will end up in the platform release though, not under stream.
Stream metadata is currently provided by the registry. So if this into is to be associated with a stream, it would have to be implemented in the registry.

@gastaldi
Copy link
Contributor Author

@aloubyansky Now that you mention I think it makes sense to have this in the platform release metadata. That would give us finer control over the recommended/minimum JDK per platform release. I'll submit a PR

@aloubyansky
Copy link
Member

@ia3andy would that work for you?

gastaldi added a commit to gastaldi/quarkus that referenced this issue Jan 10, 2023
gastaldi added a commit to gastaldi/quarkus that referenced this issue Jan 10, 2023
gastaldi added a commit to gastaldi/quarkus that referenced this issue Jan 10, 2023
gastaldi added a commit to gastaldi/quarkus that referenced this issue Jan 10, 2023
gastaldi added a commit to gastaldi/quarkus that referenced this issue Jan 10, 2023
gastaldi added a commit to gastaldi/quarkus that referenced this issue Jan 10, 2023
@gastaldi gastaldi self-assigned this Jan 10, 2023
gastaldi added a commit to gastaldi/quarkus that referenced this issue Jan 16, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 16, 2023
@gsmet gsmet modified the milestones: 2.17 - main, 2.13.7.Final Jan 17, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 17, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 18, 2023
@gsmet gsmet modified the milestones: 2.13.7.Final, 2.7.7.Final Jan 18, 2023
mfpc pushed a commit to mfpc/quarkus that referenced this issue Jan 19, 2023
ebullient pushed a commit to maxandersen/quarkus that referenced this issue Jan 24, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform area/registry Quarkus Extension Registry kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants