Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building master creates changes on file #2592

Closed
sebastienblanc opened this issue May 25, 2019 · 2 comments · Fixed by #2595
Closed

building master creates changes on file #2592

sebastienblanc opened this issue May 25, 2019 · 2 comments · Fixed by #2595
Labels
kind/bug Something isn't working triage/invalid This doesn't seem right

Comments

@sebastienblanc
Copy link
Contributor

Describe the bug
After Quarkus has been locally build with mvn clean install -DskipTests=true and I check git status I can see changes on files I haven'ts touched :


modified:   extensions/smallrye-context-propagation/deployment/src/test/java/io/quarkus/context/test/TransactionalBean.java
modified:   extensions/smallrye-context-propagation/runtime/src/main/java/io/quarkus/smallrye/context/runtime/SmallRyeContextPropagationTemplate.java
modified:   integration-tests/main/src/test/java/io/quarkus/it/main/ContextPropagationTestCase.java

Expected behavior
After a build i would expect only changes on the files I changed myself

To Reproduce
Steps to reproduce the behavior:

  1. mvn clean install -DskipTests=true
  2. git status

Environment (please complete the following information):

@sebastienblanc sebastienblanc added the kind/bug Something isn't working label May 25, 2019
Dufgui added a commit to Dufgui/quarkus that referenced this issue May 25, 2019
@Dufgui
Copy link
Contributor

Dufgui commented May 25, 2019

I fix the organize import, but i check the formater chek in the build before create the PR

@Dufgui
Copy link
Contributor

Dufgui commented May 25, 2019

in fact it's already checked by the build:
https://dev.azure.com/quarkus-ci/quarkus/_build/results?buildId=2353

@gsmet gsmet added the triage/invalid This doesn't seem right label Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants