Skip to content

Classes directories are not added to the classpath in dev mode #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aloubyansky opened this issue Mar 31, 2019 · 2 comments
Closed

Classes directories are not added to the classpath in dev mode #1782

aloubyansky opened this issue Mar 31, 2019 · 2 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@aloubyansky
Copy link
Member

ClassLoaderCompiler adds only JARs to the its classpath ignoring directories and everything else. In dev mode we perform workspace discovery and where possible using classes directories instead of the installed JAR artifacts. In case of a multi-module project when one of the module appears as a dependency, its classes will appear in the directory. When the main project is recompiled, the dependency on the module will be missing from the compiler's classpath.

@aloubyansky aloubyansky added the kind/bug Something isn't working label Mar 31, 2019
@aloubyansky aloubyansky self-assigned this Mar 31, 2019
aloubyansky added a commit to aloubyansky/quarkus that referenced this issue Mar 31, 2019
@cescoffier
Copy link
Member

At the same time, the target/generated-sources directory should also be managed. No?

stalep added a commit that referenced this issue Apr 1, 2019
Fix for #1782, Classes dirs are not added to the classpath in dev mode
@aloubyansky aloubyansky added this to the 0.13.0 milestone Apr 1, 2019
@aloubyansky
Copy link
Member Author

At the same time, the target/generated-sources directory should also be managed. No?

yes, it should be. I plan to review this whole thing to add proper support for multi-module dev mode. I wanted to fix the immediate issue the user faced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants