-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #36443 from gsmet/2.16.12-backports-1
2.16.12 backports 1
- Loading branch information
Showing
3 changed files
with
116 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109 changes: 109 additions & 0 deletions
109
...ttp/deployment/src/test/java/io/quarkus/vertx/http/http2/Http2RSTFloodProtectionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| package io.quarkus.vertx.http.http2; | ||
|
|
||
| import static io.vertx.core.http.HttpMethod.GET; | ||
| import static org.junit.jupiter.api.Assertions.fail; | ||
|
|
||
| import java.io.File; | ||
| import java.net.URL; | ||
| import java.util.concurrent.CountDownLatch; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import javax.enterprise.context.ApplicationScoped; | ||
| import javax.enterprise.event.Observes; | ||
|
|
||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Assumptions; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
|
||
| import io.quarkus.test.QuarkusUnitTest; | ||
| import io.quarkus.test.common.http.TestHTTPResource; | ||
| import io.quarkus.vertx.core.runtime.VertxCoreRecorder; | ||
| import io.vertx.core.http.HttpClient; | ||
| import io.vertx.core.http.HttpClientOptions; | ||
| import io.vertx.core.http.HttpClientRequest; | ||
| import io.vertx.core.http.HttpVersion; | ||
| import io.vertx.core.net.JdkSSLEngineOptions; | ||
| import io.vertx.ext.web.Router; | ||
|
|
||
| /** | ||
| * Reproduce CVE-2023-44487. | ||
| */ | ||
| public class Http2RSTFloodProtectionTest { | ||
|
|
||
| @TestHTTPResource(value = "/ping", ssl = true) | ||
| URL sslUrl; | ||
|
|
||
| @TestHTTPResource(value = "/ping") | ||
| URL url; | ||
|
|
||
| @RegisterExtension | ||
| static final QuarkusUnitTest config = new QuarkusUnitTest() | ||
| .withApplicationRoot((jar) -> jar | ||
| .addClasses(MyBean.class) | ||
| .addAsResource(new File("src/test/resources/conf/ssl-jks.conf"), "application.properties") | ||
| .addAsResource(new File("src/test/resources/conf/server-keystore.jks"), "server-keystore.jks")); | ||
|
|
||
| @Test | ||
| void testRstFloodProtectionWithTlsEnabled() throws Exception { | ||
| Assumptions.assumeTrue(JdkSSLEngineOptions.isAlpnAvailable()); //don't run on JDK8 | ||
| HttpClientOptions options = new HttpClientOptions() | ||
| .setUseAlpn(true) | ||
| .setProtocolVersion(HttpVersion.HTTP_2) | ||
| .setSsl(true) | ||
| .setTrustAll(true); | ||
|
|
||
| var client = VertxCoreRecorder.getVertx().get().createHttpClient(options); | ||
| int port = sslUrl.getPort(); | ||
| run(client, port, false); | ||
| } | ||
|
|
||
| @Test | ||
| public void testRstFloodProtection() throws InterruptedException { | ||
| HttpClientOptions options = new HttpClientOptions() | ||
| .setProtocolVersion(HttpVersion.HTTP_2) | ||
| .setHttp2ClearTextUpgrade(true); | ||
| var client = VertxCoreRecorder.getVertx().get().createHttpClient(options); | ||
| run(client, url.getPort(), true); | ||
| } | ||
|
|
||
| void run(HttpClient client, int port, boolean plain) throws InterruptedException { | ||
| CountDownLatch latch = new CountDownLatch(1); | ||
| client.connectionHandler(conn -> { | ||
| conn.closeHandler(v -> { | ||
| latch.countDown(); | ||
| }); | ||
| conn.goAwayHandler(ga -> { | ||
| Assertions.assertEquals(11, ga.getErrorCode()); | ||
| latch.countDown(); | ||
| }); | ||
| }); | ||
|
|
||
| if (plain) { | ||
| // Emit a first request to establish a connection. | ||
| // It's HTTP/1 so, does not count in the number of requests. | ||
| client.request(GET, port, "localhost", "/ping") | ||
| .compose(HttpClientRequest::send); | ||
| } | ||
|
|
||
| for (int i = 0; i < 250; i++) { // must be higher thant the NEtty limit (200 / 30s) | ||
| client.request(GET, port, "localhost", "/ping") | ||
| .onSuccess(req -> req.end().onComplete(v -> req.reset())); | ||
| } | ||
|
|
||
| if (!latch.await(10, TimeUnit.SECONDS)) { | ||
| fail("RST flood protection failed"); | ||
| } | ||
| } | ||
|
|
||
| @ApplicationScoped | ||
| public static class MyBean { | ||
|
|
||
| public void register(@Observes Router router) { | ||
| router.get("/ping").handler(rc -> { | ||
| // Do nothing. | ||
| }); | ||
| } | ||
|
|
||
| } | ||
| } |