Merge pull request #35116 from gastaldi/flyway_dev_improvements

Fix missing bits in Flyway Dev UI migration
quarkusio · Jul 31, 2023 · cc2ebbc · cc2ebbc
2 parents d00556f + f308816
commit cc2ebbc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/extensions/flyway/deployment/src/main/resources/dev-ui/qwc-flyway-datasources.js b/extensions/flyway/deployment/src/main/resources/dev-ui/qwc-flyway-datasources.js
@@ -136,9 +136,11 @@ export class QwcFlywayDatasources extends QwcHotReloadElement {
     }
 
     _clean(ds) {
-        this.jsonRpc.clean({ds: ds.name}).then(jsonRpcResponse => {
-            this._showResultNotification(jsonRpcResponse.result);
-        });
+        if (confirm('This will drop all objects (tables, views, procedures, triggers, ...) in the configured schema. Do you want to continue?')) {
+            this.jsonRpc.clean({ds: ds.name}).then(jsonRpcResponse => {
+                this._showResultNotification(jsonRpcResponse.result);
+            });
+        }
     }
 
     _migrate(ds) {
@@ -170,4 +172,4 @@ export class QwcFlywayDatasources extends QwcHotReloadElement {
     }
 
 }
-customElements.define('qwc-flyway-datasources', QwcFlywayDatasources);
+customElements.define('qwc-flyway-datasources', QwcFlywayDatasources);
diff --git a/...ns/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/devui/FlywayJsonRpcService.java b/...ns/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/devui/FlywayJsonRpcService.java
@@ -153,7 +153,7 @@ public FlywayActionResponse create(String ds) {
                     return new FlywayActionResponse("success",
                             "Initial migration created, Flyway will now manage this datasource");
                 } catch (Throwable t) {
-                    new FlywayActionResponse("error", t.getMessage());
+                    return new FlywayActionResponse("error", t.getMessage());
                 }
             }
             return errorNoScript(ds);
@@ -184,7 +184,7 @@ private Flyway getFlyway(String ds) {
         return null;
     }
 
-    static class FlywayDatasource {
+    public static class FlywayDatasource {
         public String name;
         public boolean hasMigrations;
         public boolean createPossible;
@@ -199,7 +199,7 @@ public FlywayDatasource(String name, boolean hasMigrations, boolean createPossib
         }
     }
 
-    static class FlywayActionResponse {
+    public static class FlywayActionResponse {
         public String type;
         public String message;
         public int number;