Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename microprofile-messaging-mqtt to be in sync with artifactId mqtt-quickstart #284

Closed
wants to merge 1 commit into from

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Sep 17, 2019

Rename microprofile-messaging-mqtt to be in sync with artifactId mqtt-quickstart

Also there is amqp-quickstart and kafka-quickstart, so having mqtt-quickstart aligns with that.

Note: microprofile-messaging-mqtt keyword is not mentioned in Quarkus docs, so no need to update anything there or on the site.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I would have done the opposite, for consistency reasons.

@rsvoboda
Copy link
Member Author

My main motivation was to be aligned with other messaging related quickstarts - amqp-quickstart and kafka-quickstart.

For microprofile-messaging-mqtt I didn't see direct connection between mqtt and microprofile, had to look at readme :).
It uses MicroProfile Reactive Messaging so wouldn't be microprofile-reactive-messaging-mqtt better name?

@rsvoboda
Copy link
Member Author

https://github.com/quarkusio/quarkus-quickstarts/tree/master/amqp-quickstart#quarkus-amqp-10-quickstart uses MicroProfile Reactive Messaging too, so the name should be adjusted too :) ?

@rsvoboda
Copy link
Member Author

@gsmet
Copy link
Member

gsmet commented Oct 31, 2019

Closing as I renamed all the quickstarts.

@gsmet gsmet closed this Oct 31, 2019
@rsvoboda rsvoboda deleted the mqtt-quickstart branch March 13, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants