-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for coverage for scnerario using same ports for http and https #2209
Add test for coverage for scnerario using same ports for http and https #2209
Conversation
97499c6
to
ecaa9ad
Compare
http/vertx/src/test/java/io/quarkus/ts/vertx/PortConflictIT.java
Outdated
Show resolved
Hide resolved
e71cdeb
to
20245ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one comment.
Also tested it with 3.15.1 and the quarkus is not terminated so the proces stay open and blocking port 8080 for any usage. I don't like as it can couse problems on other test which possibly using 8080 port. When I thinking about it I see WARNING [app] Service didn't start in PT5M minutes
in log so maybe it should be done on side of framework, can you look at it?
Kudos!
Is this ever going to be run with 3.15.1? If there is not an easy fix on the FW side, you can go the other way around, exclude this from execution in 3.15.1. |
I don't mind leaving it as it is. This PR should run only on fixed version so not big deal. But definitely issue with lowest priority for this would be nice as we can hit it with anywhere |
I don't think this PR should be left as it is. I think you mentioned the right thing - I just say if we know it doesn't work on 3.15.1, let's apply |
66c0e71
to
7223973
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changes, it seems good now
Summary
This PR forms part of 3.15.2 backports set 1 and adds the test coverage for quarkusio/quarkus#43373 that was fixed here quarkusio/quarkus@e24f7a3
Note: Before Quarkus 3.15.2 this scenario fails and the app hangs, currently fails.
Please select the relevant options.
run tests
phrase in comment)Checklist: