Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for @RestForm Map<String, String> handling in REST Client #2183

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add test for @RestForm Map<String, String> handling in REST Client #2183

merged 1 commit into from
Nov 13, 2024

Conversation

jcarranzan
Copy link
Contributor

Summary

This PR form part of the [3.15] 3.15.2 backports 1 (quarkusio/quarkus#43985) and adds test coverage to ensure that @RestForm Map<String, String> is properly handled in REST client requests, covering the fix for Quarkus issue #43784.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan marked this pull request as ready for review November 12, 2024 12:49
jedla97
jedla97 requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for coverage I have some minor comments

http/rest-client-reactive/src/main/java/io/quarkus/ts/http/restclient/reactive/BookClient.java Outdated Show resolved Hide resolved
...ient-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientIT.java Outdated Show resolved Hide resolved
...ient-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientIT.java Show resolved Hide resolved
jedla97
jedla97 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for udate. It's look good to me and CI is green

@jedla97 jedla97 merged commit d7630c3 into quarkus-qe:main Nov 13, 2024
7 checks passed
@jcarranzan jcarranzan mentioned this pull request Nov 21, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedla97 jedla97 jedla97 approved these changes

Assignees
No one assigned
Labels
triage/backport-3.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcarranzan @jedla97