Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Kafka version is visible in metrics, especially in native mode #1970

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Sep 3, 2024

Ensure Kafka version is visible in metrics, especially in native mode

Triggers: quarkusio/quarkus#41278 and quarkusio/quarkus#42865

Backport is blocked until fix for quarkusio/quarkus#42865 gets into Quarkus 3.8 and 3.15

FAIL: mvn clean verify -f monitoring/micrometer-prometheus-kafka-reactive -Dit.test=KafkaAndMetricsIT -Dnative -Dquarkus.platform.version=3.14.1 -Dquarkus.native.container-build=false -Dreruns=0
PASS: mvn clean verify -f monitoring/micrometer-prometheus-kafka-reactive -Dit.test=KafkaAndMetricsIT -Dnative -Dquarkus.platform.version=999-SNAPSHOT -Dquarkus.native.container-build=false

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy added triage/backport-3.8 triage/backport-3.15 BACKPORT CAREFULLY This PR may have issues, that affect backporting labels Sep 3, 2024
@fedinskiy fedinskiy merged commit fca904f into quarkus-qe:main Sep 3, 2024
8 checks passed
@jedla97 jedla97 mentioned this pull request Sep 5, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BACKPORT CAREFULLY This PR may have issues, that affect backporting triage/backport-3.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants