Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PostgreSQL image workaround #1022

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Remove PostgreSQL image workaround #1022

merged 2 commits into from
Mar 2, 2023

Conversation

jsmrcka
Copy link
Contributor

@jsmrcka jsmrcka commented Jan 30, 2023

Summary

Removes workaround for a failure reported in
quarkus-qe/quarkus-test-framework#641 and observed in #971.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

fedinskiy
fedinskiy requested changes Jan 30, 2023
View reviewed changes
sql-db/sql-app/src/test/java/io/quarkus/ts/sqldb/sqlapp/XAPostgresIT.java
@@ -11,7 +11,7 @@ public class XAPostgresIT extends AbstractSqlDatabaseIT {

static final int POSTGRESQL_PORT = 5432;

@Container(image = "${postgresql.also.latest.image}", port = POSTGRESQL_PORT, expectedLog = "listening on IPv4 address")
@Container(image = "${postgresql.latest.image}", port = POSTGRESQL_PORT, expectedLog = "listening on IPv4 address")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI says XAPostgresIT » NotFound Status 404: {"message":"No such image: postgres:15"}

@rsvoboda
Copy link
Member

@jsmrcka pls rebase and check the failures

@jsmrcka jsmrcka force-pushed the fix/postgresql-image branch 2 times, most recently from 0f22a09 to 1989e64 Compare February 16, 2023 10:14
@pjgg
Copy link
Contributor

pjgg commented Feb 27, 2023

I think that this error "message":"No such image: postgres:15" is still happening, but currently is hidden by Hibernate 6.2 integration issues

ERROR: relation "hibernate_sequence" does not exist

@pjgg
Copy link
Contributor

pjgg commented Mar 1, 2023

@jsmrcka could you rebase this branch with the latest changes?

@jsmrcka
Remove PostgreSQL image workaround
e01fc39 
Removes workaround for a failure reported in
quarkus-qe/quarkus-test-framework#641 and
observed in quarkus-qe#971.
@pjgg
Copy link
Contributor

pjgg commented Mar 1, 2023

The error is on test framework on this class DockerUtils#removeImageById

Basically is a run condition as far as I see, between these two scenarios PostgresqlDatabaseIT , XAPostgresIT and the global property ts.database.container.delete.image.on.stop=true

As a workaround, I am going to avoid deleting portgresql image on this module.

There is already an open issue on Quarkus test framework talking about this error

quarkus-qe/quarkus-test-framework#641

pjgg
pjgg approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit 119d8de into quarkus-qe:main Mar 2, 2023
@jsmrcka jsmrcka deleted the fix/postgresql-image branch March 9, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjgg pjgg pjgg approved these changes

@fedinskiy fedinskiy fedinskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsmrcka @rsvoboda @pjgg @fedinskiy