-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate quarkusRegistryClient property #249
Conversation
The property tells Quarkus Maven Plugin whether it should use the online registry to resolve extension catalog. Default is `true` for Quarkus. Thanks to the propagation, it can now be overriden when running tests by using `-DquarkusRegistryClient=false`. Fixes quarkus-qe#115.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving it! LGTM!
Not look on all tests but some of them failing because of
|
To avoid OutOfMemoryError for increased number of extensions (174 at the moment).
See the code for reasons.
@jsmrcka How is this gonna work when new branch is introduced? When we for example introduce 3.7 branch, will it fetch list of extensions for 3.7 Quarkus stream and main will be using Quarkus latest? |
@rsvoboda Extensions are being listed using this POM: https://github.com/quarkus-qe/quarkus-extensions-combinations/blob/main/src/main/resources/list-extensions.pom.xml, which imports a BOM based on root POM of the TS (or on mvn arguments, if provided). This PR does not change that. |
So the command is operating on top of generated list-extensions.pom.xml, so the right stream gets picked from the bom defined there. I still see some challenges:
Downstream:
|
Yes, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green now
Triggered https://github.com/quarkus-qe/quarkus-extensions-combinations/actions/runs/6967176672 to see the longer run |
The property tells Quarkus Maven Plugin whether it should use the online registry to resolve extension catalog. Default is
true
for Quarkus. Thanks to the propagation, it can now be overriden when running tests by using-DquarkusRegistryClient=false
.Fixes
#115.
Additional fixes:
moment).
camel-quarkus-mybatis
needs a datasource.io.quarkus:quarkus-logging-json
andio.quarkiverse.loggingjson:quarkus-logging-json
.