Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Auth Provider detection on using GKE, AKS #7

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Fix Auth Provider detection on using GKE, AKS #7

merged 1 commit into from
Sep 16, 2022

Conversation

cosad3s
Copy link
Contributor

@cosad3s cosad3s commented Sep 14, 2022

See: kubernetes/client-go#242

Without explicit import, we got:

### VERSION ###
Error: failed loading context to initialize client: no Auth Provider found for name "azure"

@mtardy
Copy link
Collaborator

mtardy commented Sep 15, 2022

Hey, thanks for taking the time to create that PR! You are correct, I should have loaded all these plugins like documented here and it makes sense to load them all in kdigger.

Just one question because I don't have the time to reproduce that bug by creating an Azure cluster, you had this issue while trying to communicate from outside an AKS cluster? Because I'm not sure in-cluster config would fail in this case (but would love to know).

@mtardy mtardy self-assigned this Sep 15, 2022
@mtardy mtardy added the bug Something isn't working label Sep 15, 2022
@cosad3s
Copy link
Contributor Author

cosad3s commented Sep 15, 2022

Yes it was outside the AKS ;) Inside no I do not think it will fail, but I could test

@mtardy
Copy link
Collaborator

mtardy commented Sep 16, 2022

Thanks a lot! I'll make a new release version after updating the dependencies to the k8s version!

@mtardy mtardy merged commit 774bf33 into quarkslab:main Sep 16, 2022
@mtardy
Copy link
Collaborator

mtardy commented Sep 30, 2022

@cosad3s
Copy link
Contributor Author

cosad3s commented Sep 30, 2022

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants