improve coding logic

quarkiverse · Jul 25, 2023 · 9c4cda3 · 9c4cda3
1 parent 9dd8fe8
commit 9c4cda3
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 12 deletions.
diff --git a/deployment/src/main/java/io/quarkiverse/quinoa/deployment/QuinoaProcessor.java b/deployment/src/main/java/io/quarkiverse/quinoa/deployment/QuinoaProcessor.java
@@ -337,9 +337,9 @@ static Path findProjectRoot(Path outputDirectory) {
             }
             if (currentPath.getParent() != null && Files.exists(currentPath.getParent())) {
                 currentPath = currentPath.getParent();
-            } else {
+             }
                 return null;
-            }
+
         } while (true);
     }
 

diff --git a/deployment/src/main/java/io/quarkiverse/quinoa/deployment/packagemanager/PackageManager.java b/deployment/src/main/java/io/quarkiverse/quinoa/deployment/packagemanager/PackageManager.java
@@ -228,9 +228,8 @@ private boolean exec(Command command) {
     private String[] runner(Command command) {
         if (isWindows()) {
             return new String[] { "cmd.exe", "/c", command.commandWithArguments };
-        } else {
+           } 
             return new String[] { "sh", "-c", command.commandWithArguments };
-        }
     }
 
     private static class HandleOutput implements Runnable {

diff --git a/deployment/src/main/resources/dev-ui/qwc-quinoa-card.js b/deployment/src/main/resources/dev-ui/qwc-quinoa-card.js
@@ -142,12 +142,11 @@ export class QwcQuinoaCard extends LitElement {
                     this.build_in_progress = false;
                     this.result = msg;
                     this._success('Packages updated or installed successfully.');
-                } else {
+                 }
                     this.build_complete = true;
                     this.build_in_progress = false;
                     this.build_error = true;
                     this._error(msg)
-                }
             });
     }
 

diff --git a/runtime/src/main/java/io/quarkiverse/quinoa/QuinoaDevProxyHandler.java b/runtime/src/main/java/io/quarkiverse/quinoa/QuinoaDevProxyHandler.java
@@ -125,9 +125,9 @@ private void forwardError(AsyncResult<HttpResponse<Buffer>> event, int statusCod
         final HttpServerResponse response = ctx.response().setStatusCode(statusCode);
         if (body != null) {
             response.send(body);
-        } else {
+        } 
             response.send();
-        }
+
     }
 
     private void forwardResponse(AsyncResult<HttpResponse<Buffer>> event, HttpServerRequest request, RoutingContext ctx,
@@ -143,9 +143,8 @@ private void forwardResponse(AsyncResult<HttpResponse<Buffer>> event, HttpServer
         final Buffer body = event.result().body();
         if (body != null) {
             response.send(body);
-        } else {
+        }  
             response.send();
-        }
 
     }
 

diff --git a/runtime/src/main/java/io/quarkiverse/quinoa/QuinoaSPARoutingHandler.java b/runtime/src/main/java/io/quarkiverse/quinoa/QuinoaSPARoutingHandler.java
@@ -34,8 +34,7 @@ public void handle(RoutingContext ctx) {
                 LOG.debugf("Quinoa is re-routing SPA request '%s' to '/'", ctx.normalizedPath());
             }
             ctx.reroute(ctx.mountPoint() != null ? ctx.mountPoint() : "/");
-        } else {
+        } 
             next(currentClassLoader, ctx);
-        }
     }
 }