-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Playwright in Runtime module and GraalVM support #95
Conversation
2b4d5a5
to
50e39a4
Compare
baadb02
to
cd3ccc5
Compare
sounds like good idea to me. whats the migration path? remove Any reason to not also provide a artifact named |
That is a good question. You are saying I could theoretically put all the |
I also thought about it :) we should try |
let me try it! |
yes and no - my main question was what the migration path was (if any) and if that was to just remove "-test" then why not just have "-test" include the new runtime one and all is good... |
Oh sorry the migration path would be if you use this now. <dependency>
<groupId>io.quarkiverse.playwright</groupId>
<artifactId>quarkus-playwright</artifactId>
<version>${playwright.version}</version>
<scope>test</scope>
</dependency> it changes to <dependency>
<groupId>io.quarkiverse.playwright</groupId>
<artifactId>quarkus-playwright-test</artifactId>
<version>${playwright.version}</version>
<scope>test</scope>
</dependency> |
OK it looks like it works! I moved the Test code into the Runtime library and just marked |
I think that's ok as the testing part is really small and won't be in the target user app. @aloubyansky any thoughts? |
You mean the optional dependency on the quarkus-junit5-internal? |
Yes |
Yep <dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-junit5</artifactId>
<optional>true</optional>
</dependency> |
What specifically do you achieve with that? |
Because we offer Unit testing classes with <dependency>
<groupId>io.quarkiverse.playwright</groupId>
<artifactId>quarkus-playwright</artifactId>
<version>${playwright.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-junit5</artifactId>
<scope>test</scope>
</dependency> and anyone wanting to use it as a runtime screen scraper can do this.... <dependency>
<groupId>io.quarkiverse.playwright</groupId>
<artifactId>quarkus-playwright</artifactId>
<version>${playwright.version}</version>
</dependency> |
Ah, not the |
I was also able to Graal substitute as Playwright uses |
This will allow using Playwright at Runtime for people who want to screen scrape.
playwright-test
System.out.println
logging with Jboss logging with Graal SubstitutionNOTE: this required me to rename the artifactId for playwright to playwright-test which is a breaking change so this should be a 2.0.0 if we go forward.