Allow Playwright in Runtime module and GraalVM support

[melloware]

This will allow using Playwright at Runtime for people who want to screen scrape.

• Allow use at runtime for people who want to use it for screen scraping or other purposes
• rename playwright to playwright-test
• Fix Playwright in Quarkus Native (not for E2E testing) #68 Native mode
• Replace System.out.println logging with Jboss logging with Graal Substitution

NOTE: this required me to rename the artifactId for playwright to playwright-test which is a breaking change so this should be a 2.0.0 if we go forward.

[maxandersen]

sounds like good idea to me. whats the migration path? remove -test but keep it in import scope test?

Any reason to not also provide a artifact named -test that just includes the non-test one ?

[melloware]

That is a good question. You are saying I could theoretically put all the test stuff in the runtime module and poeple could choose whether or not to mark it <scope>test</scope> or not?

[ia3andy]

That is a good question. You are saying I could theoretically put all the test stuff in the runtime module and poeple could choose whether or not to mark it <scope>test</scope> or not?

I also thought about it :) we should try

[melloware]

let me try it!

[maxandersen]

yes and no - my main question was what the migration path was (if any) and if that was to just remove "-test" then why not just have "-test" include the new runtime one and all is good...

[melloware]

Oh sorry the migration path would be if you use this now.

<dependency>
    <groupId>io.quarkiverse.playwright</groupId>
    <artifactId>quarkus-playwright</artifactId>
    <version>${playwright.version}</version>
    <scope>test</scope>
</dependency>

it changes to

<dependency>
    <groupId>io.quarkiverse.playwright</groupId>
    <artifactId>quarkus-playwright-test</artifactId>
    <version>${playwright.version}</version>
    <scope>test</scope>
</dependency>

[melloware]

OK it looks like it works! I moved the Test code into the Runtime library and just marked junit5 as an OPTIONAL dependency.

[ia3andy]

I think that's ok as the testing part is really small and won't be in the target user app. @aloubyansky any thoughts?

[aloubyansky]

You mean the optional dependency on the quarkus-junit5-internal?

[ia3andy]

Yes

[melloware]

Yep

 <dependency>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-junit5</artifactId>
            <optional>true</optional>
        </dependency>

[aloubyansky]

What specifically do you achieve with that?

[melloware]

Because we offer Unit testing classes with @WithPlaywright that are QuarkusTest only but also allow PlayWright to be used as a ScreenScraper. So anyone using it as a Test library will do this...

<dependency>
    <groupId>io.quarkiverse.playwright</groupId>
    <artifactId>quarkus-playwright</artifactId>
    <version>${playwright.version}</version>
    <scope>test</scope>
</dependency>
<dependency>
     <groupId>io.quarkus</groupId>
      <artifactId>quarkus-junit5</artifactId>
       <scope>test</scope>
</dependency>

and anyone wanting to use it as a runtime screen scraper can do this....

<dependency>
    <groupId>io.quarkiverse.playwright</groupId>
    <artifactId>quarkus-playwright</artifactId>
    <version>${playwright.version}</version>
</dependency>

[aloubyansky]

Ah, not the internal one and the user has to still add the dependency on the quarkus-junit5 - sure, makes sense. Thanks.

[melloware]

I was also able to Graal substitute as Playwright uses System.out.println for logging with Jboss logging!