-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CRDUtils::apply by replacing serverSideApply() with get(), update() and create() #660
Fix CRDUtils::apply by replacing serverSideApply() with get(), update() and create() #660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , see my comment below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest not sure if is this absolutely correct to have this based on ssaBasedCreateUpdateMatchForDependentResources
since that is for completely other think.
IMO the apply of CRD could be done just by simple create / update. Since those are anwywas not managed by controllers.
@metacosm what do you think?
Yeah, I'm also not sure if that's really a good configuration to use. My first approach was just using |
I think the CRD apply should just use get/create/update, the SSA should be removed from here. |
Yes, I think we can remove SSA altogether from this, this was an overzealous change on my part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove SSA altogether and change the commit message to follow the conventional commit format.
d73e005
to
41e4b94
Compare
41e4b94
to
1698ad3
Compare
The code is updated. I hope I've anticipated the commit message format correctly. |
will try to fix the workflows before merge |
Thank you @Donnerbart |
Fixes #659