Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRDUtils::apply by replacing serverSideApply() with get(), update() and create() #660

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

Donnerbart
Copy link
Contributor

Fixes #659

Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , see my comment below

@csviri csviri requested a review from metacosm July 18, 2023 08:07
Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest not sure if is this absolutely correct to have this based on ssaBasedCreateUpdateMatchForDependentResources since that is for completely other think.

IMO the apply of CRD could be done just by simple create / update. Since those are anwywas not managed by controllers.

@metacosm what do you think?

@Donnerbart
Copy link
Contributor Author

Yeah, I'm also not sure if that's really a good configuration to use. My first approach was just using get(), update() and create(). Just tell me what you think, I can quickly adapt the code if needed.

@csviri
Copy link
Contributor

csviri commented Jul 18, 2023

I think the CRD apply should just use get/create/update, the SSA should be removed from here.

@metacosm
Copy link
Member

Yes, I think we can remove SSA altogether from this, this was an overzealous change on my part.

Copy link
Member

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove SSA altogether and change the commit message to follow the conventional commit format.

@Donnerbart Donnerbart force-pushed the bugfix/659-fix-crdutils-apply branch from d73e005 to 41e4b94 Compare July 18, 2023 09:57
@Donnerbart Donnerbart force-pushed the bugfix/659-fix-crdutils-apply branch from 41e4b94 to 1698ad3 Compare July 18, 2023 09:58
@Donnerbart
Copy link
Contributor Author

Donnerbart commented Jul 18, 2023

The code is updated. I hope I've anticipated the commit message format correctly.

@csviri
Copy link
Contributor

csviri commented Jul 18, 2023

will try to fix the workflows before merge

@csviri csviri merged commit 366bdd9 into quarkiverse:main Jul 18, 2023
5 checks passed
@csviri
Copy link
Contributor

csviri commented Jul 18, 2023

Thank you @Donnerbart

@Donnerbart Donnerbart deleted the bugfix/659-fix-crdutils-apply branch July 18, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus Operator SDK 6.1.1 breaks operator.start() in QuarkusTests
3 participants