Add Experiment Class for Discrete Time Crystal Experiments #249
Conversation
augustehirth
force-pushed
the
time_crystal_tasks
branch
from
0594042 to
f93cd08
Compare
augustehirth
changed the title
|
I've updated everything to do away with the Tasks paradigm and dataclasses entirely. Let me know if this is a worthwhile change. |
|
@XiaoMiQC This is the first DTC PR, ready for review. |
| for name in args: | ||
| kwargs[name] = None if name is arg else locals()[name] |
There was a problem hiding this comment.
please don't be fancy like this with tests. Keep them "DAMP" (descriptive and meaningful phrases) rather than "DRY" (don't repeat yourself)
In addition to being clunky, this test is broken when I run it
There was a problem hiding this comment.
Tests should be working properly now, and the code is less fancy.
What they do, however, hasn't changed. They still simply run every combination of default or supplied values for path coverage. This could be improved but I'm not sure how would be best.
|
cc @XiaoMiQC |
|
what's the status of this? |
3 participants
PR 1 of 6 on implementing and graphing Figures 2d through 3d of Observation of Time-Crystalline Eigenstate Order on a Quantum Processor (arxiv:2107.13571)
This PR implements the Experiment Class used in experiments, defining the parameters to a single instance of the problem (in the DTCTask case), and the function to compare multiple instances of the problem (comparison_experiments)