-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
good first issueThis issue can be resolved by someone who is not familiar with the codebase. A good starting issue.This issue can be resolved by someone who is not familiar with the codebase. A good starting issue.kind/healthFor CI/testing/release process/refactoring/technical debt itemsFor CI/testing/release process/refactoring/technical debt itemsno QC knowledge neededWant to contribute to Cirq, but don't know quantum computing? This issue is for you.Want to contribute to Cirq, but don't know quantum computing? This issue is for you.triage/acceptedA consensus emerged that this bug report, feature request, or other action should be worked onA consensus emerged that this bug report, feature request, or other action should be worked on
Description
Description of the issue
The current coverage checking script check/pytest-and-incremental-coverage relies on the coverage annotate
command which is deprecated per nedbat/coveragepy@59b07a1. The coverage
tool has json
command for producing JSON report, which should provide equivalent data as coverage annotate
.
Proposal
- update scripts check/pytest-and-incremental-coverage and check/pytest-changed-files-and-incremental-coverage to use
coverage json
instead ofcoverage annotate
- prune any orphaned code for processing
coverage annotate
output, for example in dev_tools/check_incremental_coverage_annotations.py - move settings from dev_tools/conf/.coveragerc to pyproject.toml so developers can run
check/pytest
without having to use the--cov-config=.../to/.coveragerc
option.
Benefits
- CI scripts will be future-proofed for the removal of
coverage annotate
Cirq version
1.3.0.dev at b28bfce
davidmerwin
Metadata
Metadata
Assignees
Labels
good first issueThis issue can be resolved by someone who is not familiar with the codebase. A good starting issue.This issue can be resolved by someone who is not familiar with the codebase. A good starting issue.kind/healthFor CI/testing/release process/refactoring/technical debt itemsFor CI/testing/release process/refactoring/technical debt itemsno QC knowledge neededWant to contribute to Cirq, but don't know quantum computing? This issue is for you.Want to contribute to Cirq, but don't know quantum computing? This issue is for you.triage/acceptedA consensus emerged that this bug report, feature request, or other action should be worked onA consensus emerged that this bug report, feature request, or other action should be worked on
Type
Projects
Status
No status