Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore custom isort section sorting #299

Merged
merged 9 commits into from
Apr 21, 2023
Merged

Restore custom isort section sorting #299

merged 9 commits into from
Apr 21, 2023

Conversation

paddyroddy
Copy link
Collaborator

Fixes #249. Once astral-sh/ruff#2419 is released.

@paddyroddy paddyroddy self-assigned this Apr 14, 2023
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Apr 14, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/quantumjot/btrack/299
Updated: 2023-04-20T16:28:57.493676

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.54 🎉

Comparison is base (9b54ccb) 83.92% compared to head (1a82483) 84.47%.

❗ Current head 1a82483 differs from pull request most recent head 22539c0. Consider uploading reports for the commit 22539c0 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   83.92%   84.47%   +0.54%     
==========================================
  Files          30       30              
  Lines        1904     1932      +28     
  Branches      295      294       -1     
==========================================
+ Hits         1598     1632      +34     
+ Misses        219      215       -4     
+ Partials       87       85       -2     
Impacted Files Coverage Δ
btrack/btypes.py 82.54% <100.00%> (+1.41%) ⬆️
btrack/io/hdf.py 72.79% <100.00%> (ø)
btrack/io/utils.py 88.37% <100.00%> (ø)
btrack/napari/main.py 73.33% <100.00%> (ø)
btrack/napari/reader.py 72.41% <100.00%> (ø)
btrack/utils.py 82.88% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paddyroddy
Copy link
Collaborator Author

Code changes are just from running ruff.

@paddyroddy paddyroddy marked this pull request as ready for review April 20, 2023 16:25
Copy link
Collaborator

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to have the custom isort sections!

Code changes are just from running ruff.

just wondering why the formatting wasn't applied automatically previously? Shouldn't the pr linting checks pick up any changes that would be made? Or is there something else that is being changed here in the configuration apart from the custom isort sections?

@paddyroddy
Copy link
Collaborator Author

paddyroddy commented Apr 21, 2023

There will have been a bug in an earlier version of ruff.

@paddyroddy paddyroddy merged commit 666821e into main Apr 21, 2023
@paddyroddy paddyroddy deleted the fix-issue-249 branch April 21, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom isort sections once ruff has them
3 participants