ENH Plot max and median long/short exposures #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A potentially misleading part of this plot is the fact that median takes the average two position concentrations when there are an even number of longs or shorts. |
| The positions that the strategy takes over time. | ||
| ax : matplotlib.Axes, optional | ||
| Axes upon which to plot. | ||
| **kwargs, optional |
There was a problem hiding this comment.
Still doesn't do anything with kwars below.
It should take the average between the two center values if there's an even number but that's fine and expected. Otherwise LGTM. |
| @@ -97,6 +97,37 @@ def get_top_long_short_abs(positions, top=10): | |||
| return df_top_long, df_top_short, df_top_abs | |||
|
|
|||
|
|
|||
| def get_max_median_position_conc(positions): | |||
There was a problem hiding this comment.
get_max_median_position_concentration
a-campbell
force-pushed
the
pos-concentration
branch
from
b266b70
to
e469e06
Compare
|
Should be good to go now. |
a-campbell
force-pushed
the
pos-concentration
branch
from
e469e06
to
103be26
Compare
a-campbell
added a commit
that referenced
this pull request
Dec 8, 2015
ENH Plot max and median long/short exposures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #218