Added truncate for SampleSet distribution #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for squiggle-documentation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for squiggle-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## develop #995 +/- ##
===========================================
+ Coverage 57.85% 57.87% +0.01%
===========================================
Files 74 74
Lines 4114 4123 +9
===========================================
+ Hits 2380 2386 +6
- Misses 1734 1737 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that truncate would break correlations. Order (correlations) is not preserved, because many items are just filtered out.
I expect that getting around this tricky. There are some hacks, like having "null" samples. I imagine at some point, we'd likely want to have a more rigorous take and have "tagged" samples. Each sample comes with a unique ID that lasts over its runtime. This is a bit tricky because of the graph structure of it. This can wait for later though.