-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground style updates #3182
Open
OAGr
wants to merge
25
commits into
main
Choose a base branch
from
playground-style-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Playground style updates #3182
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
d2a2114
Improving Playground styles, added IconByName in UI
OAGr 5a3a655
Thinner chevron icons
OAGr d6abd41
Merge branch 'main' of https://github.com/quantified-uncertainty/squi…
OAGr 69eba71
Light color changes
OAGr e341ca3
Merged with squigglechart-path-fix
OAGr be4f0b3
Better pass at version picker button
OAGr 53be9aa
green -> emerald
OAGr 0adb271
Merge branch 'style-updates-april-2024' into playground-style-updates
OAGr af1e68b
Merge branch 'style-updates-april-2024' into playground-style-updates
OAGr 1fc00c6
Merge branch 'style-updates-april-2024' into playground-style-updates
OAGr bdd8a67
Ran formatter, fixed other linter errors
OAGr e42196c
Minor fixes
OAGr e2b8d18
Minor touch-ups to playground colors
OAGr 35ac262
SquiggleViewer to use cyan instead of purple
OAGr e6188a8
Adjustments in ui colors. Slate->gray, indigo->blue
OAGr bb076cf
Added StyledToggle, some refactoring
OAGr 363a0dd
Changing version picker
OAGr 013c8c6
Removed StyledToggle export from UI, as it was stopping Hub building
OAGr c434140
Integrated SquigglePlaygroundVersionPickerDropdown
OAGr 0cfd698
Version picker cleanup
OAGr a80f79d
Merge branch 'style-updates-april-2024' into playground-style-updates
OAGr 59e7bc1
Added changeset
OAGr 283f9b5
Minor reversion and fixes
OAGr 0da0523
Merge branch 'main' into playground-style-updates
OAGr db6de0c
Added lint override for stories
OAGr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@quri/versioned-squiggle-components": patch | ||
"@quri/squiggle-components": patch | ||
"@quri/ui": patch | ||
--- | ||
|
||
Updated playground styles to look more professional, added StyledToggle |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,12 +137,12 @@ export const ValueWithContextViewer: FC<Props> = ({ | |
return ( | ||
<div | ||
className={clsx( | ||
"mr-1.5 flex w-4 cursor-pointer justify-center hover:!text-stone-600", | ||
isOpen ? "text-stone-600 opacity-40" : "text-stone-800 opacity-40" | ||
"mr-1.5 flex w-4 cursor-pointer justify-center hover:!text-gray-600", | ||
isOpen ? "text-gray-200" : "text-gray-500" | ||
)} | ||
onClick={handle.toggleCollapsed} | ||
> | ||
<Icon size={13} /> | ||
<Icon size={9} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The clickable area is now 16x9, while it was 16x13 in v0.9.3. If the icon is smaller now, is it possible to add vertical padding to the clickable div around it? |
||
</div> | ||
); | ||
} else { | ||
|
@@ -158,7 +158,7 @@ export const ValueWithContextViewer: FC<Props> = ({ | |
className="group flex w-4 shrink-0 cursor-pointer justify-center" | ||
onClick={handle.toggleCollapsed} | ||
> | ||
<div className="w-px bg-stone-100 group-hover:bg-stone-400" /> | ||
<div className="w-px bg-gray-50 group-hover:bg-gray-300" /> | ||
</div> | ||
); | ||
} else { | ||
|
@@ -178,10 +178,8 @@ export const ValueWithContextViewer: FC<Props> = ({ | |
}} | ||
tabIndex={viewerType === "tooltip" ? undefined : 0} | ||
className={clsx( | ||
"group flex justify-between rounded-sm pr-0.5 hover:bg-stone-100 focus-visible:outline-none", | ||
isZoomedIn | ||
? "mb-2 px-0.5 py-1 focus:bg-indigo-50" | ||
: "focus:bg-indigo-100" | ||
"group flex justify-between rounded-sm pr-0.5 hover:bg-gray-100 focus:bg-slate-100 focus-visible:outline-none", | ||
isZoomedIn && "mb-2 px-0.5 py-1" | ||
)} | ||
onFocus={(_) => { | ||
scrollEditorToPath(); | ||
|
@@ -239,7 +237,7 @@ export const ValueWithContextViewer: FC<Props> = ({ | |
className={clsx( | ||
"cursor-pointer transition", | ||
isRootImport | ||
? "text-violet-400 hover:!text-violet-900 group-hover:text-violet-500 group-focus:text-violet-600" | ||
? "text-cyan-200 hover:!text-cyan-900 group-hover:text-cyan-700 group-focus:text-cyan-700" | ||
: "text-slate-200 hover:!text-slate-900 group-hover:text-slate-400 group-focus:text-slate-400" | ||
)} | ||
/> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lack of colon makes it harder to interpret the results:
In general, I'm concerned about optimizing UI by removing things that are visual cruft when you're an expert at the playground and understand which element is which, but that were very helpful for people who don't understand yet what's going on.
This specific case is minor, though, and I'd prefer that we wrap array indices in
[]
instead of using colons. Also it's less of a problem than this (which is a problem both in this PR and before):