Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed samples and xyPointLength from 10K to 1K #1033

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Changed samples and xyPointLength from 10K to 1K #1033

merged 1 commit into from
Aug 30, 2022

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Aug 30, 2022

@netlify
Copy link

netlify bot commented Aug 30, 2022 •
edited
Loading

✅ Deploy Preview for squiggle-documentation ready!

Name Link
🔨 Latest commit 4368bb5
🔍 Latest deploy log https://app.netlify.com/sites/squiggle-documentation/deploys/630d5f70f9c6ab0007b5bbea
😎 Deploy Preview https://deploy-preview-1033--squiggle-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OAGr OAGr marked this pull request as ready for review August 30, 2022 00:53
@OAGr OAGr requested a review from Hazelfire as a code owner August 30, 2022 00:53
@netlify
Copy link

netlify bot commented Aug 30, 2022 •
edited
Loading

✅ Deploy Preview for squiggle-components ready!

Name Link
🔨 Latest commit 4368bb5
🔍 Latest deploy log https://app.netlify.com/sites/squiggle-components/deploys/630d5f706ce40c0008824feb
😎 Deploy Preview https://deploy-preview-1033--squiggle-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OAGr OAGr merged commit c7bc526 into develop Aug 30, 2022
@OAGr OAGr deleted the 10k-to-1k-default branch August 30, 2022 01:10
@berekuk
Copy link
Collaborator

berekuk commented Sep 1, 2022

Uh... I think this defaultSamplingInputs was completely unused. It's not mentioned anywhere else in the codebase.

Default env comes from here:

squiggle/packages/squiggle-lang/src/rescript/MagicNumbers.res

Line 12 in a97d1ba

module Environment = {

And it's 1K/10K. (But overridden to 1K/1K in Playground).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hazelfire Hazelfire Awaiting requested review from Hazelfire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OAGr @berekuk