Skip to content

Updated the pre flight check yml file #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sudeeshna21 wants to merge 1 commit into
base: qualcomm-software
Choose a base branch
from
Open

Updated the pre flight check yml file #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 19 additions & 25 deletions .github/workflows/qcom-preflight-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,25 @@
name: Qualcomm Preflight Checks
name: QC Preflight Checks

on:
# FIXME: these branch targets might need to be revisited to make this work
# as we create new release branches.
pull_request_target:
branches:
- 'qualcomm-software'
- 'release/qualcomm-software/**'
pull_request:
branches: [qualcomm-software, release/qualcomm-software/**]
push:
branches:
- 'qualcomm-software'
- 'release/qualcomm-software/**'
branches: [qualcomm-software, release/qualcomm-software/**]
workflow_dispatch:

permissions:
contents: read
security-events: write

jobs:
qcom-preflight-checks:
if: github.repository == 'qualcomm/cpullvm-toolchain'
Copy link
Copy Markdown
Contributor

@jonathonpenix jonathonpenix Mar 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be removed--please either re-add this or explain why it isn't needed anymore (ex: if it is expected to work on forks out-of-the-box now, etc.)

Copy link
Copy Markdown

@mynameistechno mynameistechno Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work on forks - not sure why that was originally there

Copy link
Copy Markdown
Contributor

@jonathonpenix jonathonpenix Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added as one of the checks (semgrep? something else? I forget) required additional security permissions that require extra setup (and generally getting notifications about failed runs in forks is just noise when it is coming out of the main repo).

Copy link
Copy Markdown

@mynameistechno mynameistechno Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it was because the past workflow required an org level secret. We've removed that requirement

Copy link
Copy Markdown
Contributor

@jonathonpenix jonathonpenix Mar 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is/was some Advanced Security/Dependency Graph setting: #23

Copy link
Copy Markdown

@mynameistechno mynameistechno Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah that is annoying. We added a check that skips the dep review if it's not enabled https://github.com/qualcomm/qcom-reusable-workflows/blob/main/.github/workflows/reusable-dependency-review.yml#L10

uses: qualcomm/qcom-reusable-workflows/.github/workflows/qcom-preflight-checks-reusable-workflow.yml@v1.1.4
preflight:
name: Run QC Preflight Checks
uses: qualcomm/qcom-reusable-workflows/.github/workflows/reusable-qcom-preflight-checks-orchestrator.yml@v2
with:
# ✅ Preflight Checkers
repolinter: false # default: true
semgrep: true # default: true
copyright-license-detector: true # default: true
pr-check-emails: true # default: true
dependency-review: true # default: true
secrets:
SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }}
enable-semgrep-scan: true
enable-dependency-review: true
enable-repolinter-check: false
enable-copyright-license-check: true
enable-commit-email-check: true
enable-commit-msg-check: false
enable-armor-checkers: false

permissions:
contents: read
security-events: write
Loading