Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zero value incorect comparison #12

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

quagmt
Copy link
Owner

@quagmt quagmt commented Oct 17, 2024

Issue

Description

  • Make zero value always udecimal.Zero to avoid unexpected result when comparing zero
    cc @mdawar

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (9d5eef5) to head (634d488).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   94.53%   94.54%           
=======================================
  Files           5        5           
  Lines        1263     1265    +2     
=======================================
+ Hits         1194     1196    +2     
  Misses         37       37           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quagmt quagmt changed the title Fix: zero value incorect comparison fix: zero value incorect comparison Oct 17, 2024
@quagmt quagmt merged commit 603c3aa into master Oct 17, 2024
10 checks passed
@quagmt quagmt deleted the fix/zero-value-incorect-comparison branch October 17, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant