chore: remove more mui #2585
chore: remove more mui #2585
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Preview - Build & Deploy Images✅ Build images 🕒 Last deployed: Mar 28, 2025 at 04:42 PM UTC |
| ], | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Replaced all these with their (roughly) equivalents in tailwind.
| @@ -99,7 +100,7 @@ const commands: CommandGroup = { | |||
| label: 'Date and time format', | |||
| isAvailable: isAvailableBecauseCanEditFile, | |||
| Component: (props) => { | |||
| return <CommandPaletteListItem {...props} action={props.openDateFormat} icon={<DateRangeIcon />} />; | |||
| return <CommandPaletteListItem {...props} action={props.openDateFormat} icon={<FormatDateTimeIcon />} />; | |||
There was a problem hiding this comment.
Use the same icon we're using elsewhere (like the toolbar)
| <Button asChild variant="outline" size="sm"> | ||
| <Link to={ROUTES.LOGIN_WITH_REDIRECT()}>Log in</Link> | ||
| </Button> | ||
| <Button size="sm"> | ||
| <Link to={ROUTES.SIGNUP_WITH_REDIRECT()}>Sign up</Link> | ||
| </Button> | ||
| </Stack> | ||
| </div> |
There was a problem hiding this comment.
No visual change here. Identical to before
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #2585 +/- ##
=======================================
Coverage 90.39% 90.39%
=======================================
Files 383 383
Lines 86262 86262
=======================================
Hits 77973 77973
Misses 8289 8289 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| message={message} | ||
| /> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
File wasn't being used anywhere
| @@ -147,7 +147,7 @@ export const SheetRange = (props: Props) => { | |||
| side="bottom" | |||
| > | |||
| <Button size="sm" onClick={onInsert} disabled={disableButton}> | |||
| <HighlightAltIcon fontSize="small" /> | |||
| <InsertCellRefIcon /> | |||
There was a problem hiding this comment.
Use the existing 'insert cell ref' icon
| ) : ( | ||
| <Box style={styles}>{inner}</Box> | ||
| <div className={classNames}>{inner}</div> |
There was a problem hiding this comment.
Use standard tokens for theming, including standard font size.
Because this makes the sheet bar and the bottom bar have a similar visual weight, I made the sheet bar normal black and bottom bar muted, providing emphasized hierarchy between these two (and the sheet)
| @@ -14,6 +14,7 @@ import { javascriptWebWorker } from '@/app/web-workers/javascriptWebWorker/javas | |||
| import type { LanguageState } from '@/app/web-workers/languageTypes'; | |||
| import { pythonWebWorker } from '@/app/web-workers/pythonWebWorker/pythonWebWorker'; | |||
| import { quadraticCore } from '@/app/web-workers/quadraticCore/quadraticCore'; | |||
| import { StopIcon } from '@/shared/components/Icons'; | |||
There was a problem hiding this comment.
no visual change. just use the one from our collection rather than mui
| import { useCallback, useEffect, useMemo, useRef, useState } from 'react'; | ||
|
|
||
| const SHOW_SELECTION_SUMMARY_DELAY = 500; | ||
| const DECIMAL_PLACES = 2; | ||
|
|
||
| export const SelectionSummary = () => { | ||
| const isBigEnoughForActiveSelectionStats = useMediaQuery('(min-width:1000px)'); |
There was a problem hiding this comment.
Hide via CSS rather than special mui JS hook
| @@ -37,7 +37,7 @@ export function EducationDialog() { | |||
| <DialogContent className="max-w-sm"> | |||
| <DialogHeader className="text-center sm:text-center"> | |||
| <div className="flex flex-col items-center gap-2 py-4"> | |||
| <SchoolOutlined sx={{ fontSize: '64px' }} className="text-primary" /> | |||
| <EducationIcon className="text-primary" size="2xl" /> | |||
There was a problem hiding this comment.
No big visual change here, just swapping the mui icon for the one from material (had to add scaling to the base Icon component).
| > | ||
| {sheet.name} | ||
| </Box> | ||
| </div> |
There was a problem hiding this comment.
No visual changes.
| }} | ||
| /> | ||
| ); | ||
| } |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
| muiColors.blueGrey['600'], | ||
| muiColors.lime['900'], | ||
| muiColors.brown['500'], | ||
| tailwindColors.orange['600'], |
There was a problem hiding this comment.
I have no clue how these numbers match up. Maybe the UI reviewer can validate color consistency of this branch and main?
There was a problem hiding this comment.
I had to figure out how these matched up doing the work ha, so I just took a screenshot. It's on a comment I left
|
@jimniels lints are failing in CI. |
|
@ddimaria thx for the tip. Ran prettier locally and made all fixes. Should pass now... |
Removing more mui dependencies. See inline comments for changes