Skip to content

Work correctly on Ruby 3.5 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Work correctly on Ruby 3.5 #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/m/test_method.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ def self.create suite_class, test_method
# look up the ruby Method instance for it
method = suite_class.instance_method test_method

# Ruby can find the starting line for us, so pull that out of the array
start_line = method.source_location.last
# Ruby can find the starting line for us, so pull that out of the array.
# Ruby 3.5+ can also provide the ending line.
start_line, end_line = method.source_location.values_at(1, 3)

# Ruby can't find the end line however, and I'm too lazy to write
# Ruby < 3.5 can't find the end line however, and I'm too lazy to write
# a parser. Instead, `method_source` adds `Method#source` so we can
# deduce this ourselves.
#
# The end line should be the number of line breaks in the method source,
# added to the starting line and subtracted by one.

end_line = method.source.split("\n").size + start_line - 1
end_line ||= method.source.split("\n").size + start_line - 1

# Shove the given attributes into a new databag
new test_method, start_line, end_line
Expand Down