Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mod): update ipfs & libp2p deps #985

Merged
merged 2 commits into from
Oct 25, 2019
Merged

chore(mod): update ipfs & libp2p deps #985

merged 2 commits into from
Oct 25, 2019

Conversation

b5
Copy link
Member

@b5 b5 commented Oct 25, 2019

let's try to be a little speedier with these in the future :)

This moves us over to some random commit of IPFS (we can sync to the latest patch once it comes out). but more importantly updates our libp2p dependencies to use go-libp2p-core

@b5 b5 added the chore Changes to the build process or auxiliary tools and libraries such as documentation generation label Oct 25, 2019
@b5 b5 self-assigned this Oct 25, 2019
let's try to be a little speedier with these in the future :)
CI seems to need a little more time to get a hold of the port. would be nice if we used a channel to indicate connectness...
Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -47,7 +47,8 @@ func TestFetchCommand(t *testing.T) {
}
}()

time.Sleep(time.Second * 2)
// TODO (b5) - this is horrible. we should block on a channel receive for connectedness
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@b5 b5 merged commit 79fa6e7 into master Oct 25, 2019
@b5 b5 deleted the chore_update_ipfs_deps branch October 25, 2019 21:03
@b5 b5 mentioned this pull request Mar 30, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes to the build process or auxiliary tools and libraries such as documentation generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants