Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client ID and subscribed topics #15

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Fix client ID and subscribed topics #15

merged 1 commit into from
Dec 29, 2023

Conversation

qqaatw
Copy link
Owner

@qqaatw qqaatw commented Dec 29, 2023

Summary:

  1. Fix client ID and subscribed topics to comply with the policy.
  2. Update minimally supported Python version to 3.9.
  3. Change formatter from black to ruff-format.
  4. Remove unnecessary http requests.
  5. Update awsiotsdk version to 1.20.0.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ad6083b) 92.28% compared to head (988cd86) 92.18%.

Files Patch % Lines
JciHitachi/aws_connection.py 80.00% 3 Missing ⚠️
JciHitachi/model.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   92.28%   92.18%   -0.11%     
==========================================
  Files           8        8              
  Lines         804      793      -11     
==========================================
- Hits          742      731      -11     
  Misses         62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qqaatw qqaatw changed the title [Draft] Fix client ID and subscribed topics Dec 29, 2023
@qqaatw qqaatw marked this pull request as ready for review December 29, 2023 07:22
@qqaatw qqaatw merged commit 503872e into master Dec 29, 2023
7 of 9 checks passed
@qqaatw qqaatw deleted the fix_14 branch January 21, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant