Don't use URLDecoder to decode file URLs in ConfigurationWatchList #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java's `File#toURI` method does not encode all reserved URI characters like the `+` character, because they only need to be encoded in other parts of the URI. The `java.net.URLDecoder` on the other hand expects the `x-www-form-urlencode` encoding and therefore replaces these characters. Automatic reloading of logback configuration files in directories with the `+` did therefore not work. Fixes qos-ch#950 Signed-off-by: Daniel Meier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java's
File#toURImethod does not encode all reserved URI characters like the+character, because they only need to be encoded in other parts of the URI. Thejava.net.URLDecoderon the other hand expects thex-www-form-urlencodeencoding and therefore replaces these characters. Automatic reloading of logback configuration files in directories with the+did therefore not work. Fixes #950