Provide servlet request listener which fill the MDC #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csware
commented
Jan 19, 2024
| public class MDCInsertingServletRequestListener implements ServletRequestListener { | ||
| @Override | ||
| public void requestInitialized(ServletRequestEvent sre) { | ||
| insertIntoMDC(sre.getServletRequest()); |
There was a problem hiding this comment.
Here, we could also call the insertIntoMDC in the MDCInsertingServletFilter to avoid code duplication.
This is seen as superior to a filter as the MDC is not cleared before an error handler servlet is executed. Signed-off-by: Sven Strickroth <[email protected]>
csware
force-pushed
the
mdc-servlet-request-listener
branch
from
52818a8 to
f1ba14a
Compare
|
TODO: The documentation needs updating... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is seen as superior to a filter as the MDC is not cleared before an error handler servlet is executed.
cf. PR #768