fix: a few regressions from previous PRs - #21
Conversation
| *self.window_id.lock().unwrap(), | ||
| self.webview_id, | ||
| WebviewMessage::DeleteCookie(cookie.clone().into_owned()), | ||
| WebviewMessage::SetCookie(cookie.into_owned()), |
There was a problem hiding this comment.
Bug: The delete_cookie function incorrectly sends a WebviewMessage::SetCookie message instead of WebviewMessage::DeleteCookie, causing it to set cookies instead of deleting them.
Severity: HIGH
Suggested Fix
In the delete_cookie function, change the message being sent from WebviewMessage::SetCookie(cookie.into_owned()) to WebviewMessage::DeleteCookie(cookie.into_owned()) to match the function's intent and the corresponding message handler.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: crates/tauri-runtime-wry/src/lib.rs#L1718
Potential issue: The `delete_cookie` method in `WryWebviewDispatcher<T>` is implemented
to send a `WebviewMessage::SetCookie` message. However, the message handler has a
distinct and separate logic path for `WebviewMessage::DeleteCookie`. As a result, any
application call to `delete_cookie` will perform the opposite of its intended operation
by setting or updating the cookie instead of removing it. This breaks a fundamental
browser operation, preventing applications from clearing session data, which can have
privacy and security implications.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#170