fix: a few regressions from previous PRs - #20
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| *self.window_id.lock().unwrap(), | ||
| self.webview_id, | ||
| WebviewMessage::DeleteCookie(cookie.clone().into_owned()), | ||
| WebviewMessage::SetCookie(cookie.into_owned()), |
There was a problem hiding this comment.
delete_cookie now sets cookie instead of deleting
High Severity
The delete_cookie function sends WebviewMessage::SetCookie instead of WebviewMessage::DeleteCookie. This causes the function to set the cookie rather than delete it, completely inverting the intended behavior. The DeleteCookie message variant exists and correctly calls webview.delete_cookie() in the handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#170
Note
Cookiefromtauri_runtimeinwebview/mod.rs(removing directcookie::Cookieimport) and changesdelete_cookieto dispatchWebviewMessage::SetCookieinstead ofDeleteCookieintauri-runtime-wry.WebviewWindowBuilder::with_window_featurestowindow_featuresand updates docs and examples accordingly; also tweaks application order offeatures.size()andfeatures.position().on_new_windowusage, updates window labels, and applies the new.window_features(features)chain.Written by Cursor Bugbot for commit bb976cd. Configure here.