[CLEAN] Synthetic Benchmark PR #139226 - Consistently use slf4j/log4j bridge#79
Open
bar-qodo wants to merge 1 commit intobase_pr_139226_20260113_9328from
Open
[CLEAN] Synthetic Benchmark PR #139226 - Consistently use slf4j/log4j bridge#79bar-qodo wants to merge 1 commit intobase_pr_139226_20260113_9328from
bar-qodo wants to merge 1 commit intobase_pr_139226_20260113_9328from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR elastic#139226
Type: Clean (correct implementation)
Original PR Title: Consistently use slf4j/log4j bridge
Original PR Description: Some 3rd party dependencies use SLF4J but Elasticsearch internally uses log4j. Historically there were problems with using the log4j adapter for SLF4J, but those have gone away with the removal of SecurityManager. This commit updates uses of slf4j to consistently use the log4j bridge. Note that long term we should still aim for something more turnkey so that we don't end up with multiple copies of the bridge jar, but this change at least removes warnings about no SLF4J providers being found.
closes elastic#137556
Original PR URL: elastic#139226