Improve Blazor reconnection experience after the server is restarted#8
Conversation
…flect change in ResumeCircuit
Author
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| } | ||
| } else { | ||
| this.reloadButton.style.display = 'none'; | ||
| this.rejoiningAnimation.style.display = 'none'; |
There was a problem hiding this comment.
Animation not hidden when displaying pause state
Medium Severity
The rejoiningAnimation is not hidden in the update() method's pause branch. When show() is called, it sets the animation to visible (display: 'block'). Previously, update() with type: 'pause' would hide the animation, but that line was removed. Now users will see the pulsing animation alongside the static "The session has been paused by the server." message and Resume button, creating a confusing UI state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#32
Note
Improves resiliency and clarity of Blazor Server reconnection/resume.
ComponentHub.ResumeCircuitno longer sends client errors or aborts when persisted state is unavailable; relies on client reconnection logic; unit tests updated accordinglyDefaultReconnectDisplayandDefaultReconnectionHandlertweak button visibility and flow (hide resume during reconnect; show resume on resume-failed; stop forcing pause update before resume);UserSpecifiedDisplayexposesremotein events and tracks reconnect stateWritten by Cursor Bugbot for commit f287efa. Configure here.