[release/10.0] Source code updates from dotnet/dotnet - #11
Conversation
🤖 Augment PR SummarySummary: Syncs this branch with a newer dotnet/dotnet source snapshot for the 10.0 release train. Changes:
Technical Notes: The dependency updates keep source-build/tooling coherent with dotnet/dotnet; the E2E test changes affect Selenium navigation and browser history assumptions. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| Navigate($"{ServerPathBase}/redirect"); | ||
|
|
||
| _originalH1Element = Browser.Exists(By.TagName("h1")); | ||
| Navigate($"{ServerPathBase}/redirect"); |
There was a problem hiding this comment.
Navigate(...) happens after capturing _originalH1Element, but Navigate does a full reload (via about:blank), so the stored IWebElement is likely from a previous page and/or becomes stale and causes Browser.Equal(... _originalH1Element.Text) to time out. Consider navigating first, then capturing the <h1> from the redirected page.
🤖 Was this useful? React with 👍 or 👎
|
|
||
| // See that 'back' takes you to the place from before the redirection | ||
| Browser.Navigate().Back(); | ||
| Browser.Navigate().Forward(); |
There was a problem hiding this comment.
This switches from Back() to Forward() while the comment (and expected behavior) is about going back to the pre-redirection page; Forward() typically won’t change anything unless you’ve already navigated back. This looks like it would leave the browser on the redirected page and make the subsequent assertions unreliable.
🤖 Was this useful? React with 👍 or 👎
| } | ||
|
|
||
| [Fact] | ||
| [TestMethod] |
There was a problem hiding this comment.
This test file is using xUnit ([Theory], implicit Xunit using), so changing [Fact] to MSTest [TestMethod] may stop the test from being discovered, and also makes [QuarantinedTest] (an xUnit trait attribute) ineffective. If the goal is quarantine rather than disable discovery, it’s worth double-checking the intended runner/attribute combination.
🤖 Was this useful? React with 👍 or 👎
2 participants
Benchmark PR from qodo-benchmark#78