-
Notifications
You must be signed in to change notification settings - Fork 7
feat(ci): add structural workflow-policy YAML authority (S4) #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d357b87
feat(ci): add structural workflow-policy YAML authority (S4)
qnbs 3c8408b
test(tooling): cover workflow-policy-check structural rules
qnbs d67cd02
docs: sync README test-metrics badge
qnbs 2934bc1
fix: close review-wave findings in workflow-policy-check (S4)
qnbs cff962a
fix: verify ci-success actually checks each gating job's result
qnbs a792127
fix: close review-wave-3 findings in workflow-policy-check (S4)
qnbs 8913e92
fix: resolve aliases at every container boundary in workflow-policy-c…
qnbs 8c5ad4f
docs: sync README test-metrics badge to 7064 tests
qnbs 3e0c110
fix: gate CI on workflow-policy before governed actions run (S4)
qnbs e9f4bf2
fix: update stale ci-success.needs expectation for the new workflow-p…
qnbs 05d7e84
fix: close 6 review-wave-6 gaps in workflow-policy-check and its CI gate
qnbs c8bd941
fix: run workflow-policy-check via node directly, not pnpm run
qnbs a05e1c3
fix: close 2 more review-wave-7 gaps, defer the gate's own trust boun…
qnbs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| import type { Document, LineCounter } from 'yaml'; | ||
|
|
||
| export interface WorkflowPolicyFailure { | ||
| file: string; | ||
| message: string; | ||
| } | ||
|
|
||
| export interface ListWorkflowFilesDependencies { | ||
| readdirSync?: (dir: string) => string[]; | ||
| } | ||
|
|
||
| export function listWorkflowFiles( | ||
| root?: string, | ||
| dependencies?: ListWorkflowFilesDependencies, | ||
| ): string[]; | ||
|
|
||
| export interface DirEntryLike { | ||
| name: string; | ||
| isDirectory(): boolean; | ||
| } | ||
|
|
||
| export interface ListActionFilesDependencies { | ||
| // QNBS-v3: recursive discovery needs Dirent-shaped entries, not listWorkflowFiles' flat string[]. | ||
| readdirSync?: (dir: string, options: { withFileTypes: true }) => DirEntryLike[]; | ||
| } | ||
|
|
||
| export function listActionFiles( | ||
| root?: string, | ||
| dependencies?: ListActionFilesDependencies, | ||
| ): string[]; | ||
|
|
||
| export interface ParseWorkflowFileDependencies { | ||
| readFileSync?: (filePath: string, encoding: 'utf8') => string; | ||
| } | ||
|
|
||
| export interface ParsedWorkflowFile { | ||
| filePath: string; | ||
| content: string; | ||
| doc: Document; | ||
| lineCounter: LineCounter; | ||
| } | ||
|
|
||
| export function parseWorkflowFile( | ||
| filePath: string, | ||
| dependencies?: ParseWorkflowFileDependencies, | ||
| ): ParsedWorkflowFile; | ||
|
|
||
| export function checkTopLevelPermissions( | ||
| fileName: string, | ||
| doc: Document, | ||
| failures: WorkflowPolicyFailure[], | ||
| ): void; | ||
|
|
||
| export function checkJobWriteScopeAllowlist( | ||
| fileName: string, | ||
| doc: Document, | ||
| failures: WorkflowPolicyFailure[], | ||
| ): void; | ||
|
|
||
| export function checkNeedsGraph( | ||
| fileName: string, | ||
| doc: Document, | ||
| failures: WorkflowPolicyFailure[], | ||
| ): void; | ||
|
|
||
| export interface CheckActionPinsOptions { | ||
| fileKind?: 'workflow' | 'action'; | ||
| lineCounter?: LineCounter; | ||
| } | ||
|
|
||
| export function checkActionPins( | ||
| fileName: string, | ||
| doc: Document, | ||
| failures: WorkflowPolicyFailure[], | ||
| options?: CheckActionPinsOptions, | ||
| ): void; | ||
|
|
||
| export function checkAggregatorNeeds( | ||
| fileName: string, | ||
| doc: Document, | ||
| failures: WorkflowPolicyFailure[], | ||
| ): void; | ||
|
|
||
| export function checkPublishingBoundary( | ||
| fileName: string, | ||
| doc: Document, | ||
| failures: WorkflowPolicyFailure[], | ||
| ): void; | ||
|
|
||
| export interface WorkflowTriggers { | ||
| workflowDispatch: boolean; | ||
| tagPush: boolean; | ||
| } | ||
|
|
||
| export function getTriggers(doc: Document): WorkflowTriggers; | ||
|
|
||
| export type CheckWorkflowFileDependencies = ParseWorkflowFileDependencies; | ||
|
|
||
| export function checkWorkflowFile( | ||
| filePath: string, | ||
| dependencies?: CheckWorkflowFileDependencies, | ||
| ): WorkflowPolicyFailure[]; | ||
|
|
||
| export function checkActionFile( | ||
| filePath: string, | ||
| dependencies?: CheckWorkflowFileDependencies, | ||
| ): WorkflowPolicyFailure[]; | ||
|
|
||
| export type CheckAllWorkflowsDependencies = CheckWorkflowFileDependencies & | ||
| ListWorkflowFilesDependencies & | ||
| ListActionFilesDependencies & { | ||
| listWorkflowFiles?: (root: string) => string[]; | ||
| listActionFiles?: (root: string) => string[]; | ||
| }; | ||
|
|
||
| export function checkAllWorkflows( | ||
| root?: string, | ||
| dependencies?: CheckAllWorkflowsDependencies, | ||
| ): WorkflowPolicyFailure[]; | ||
|
|
||
| export function main(): void; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.