Skip to content

fix(cef): raise STARTUP_GRACE_MS to 15s (real post-merge CI failure) #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qnbs merged 2 commits into from
Aug 19, 2026
Merged

fix(cef): raise STARTUP_GRACE_MS to 15s (real post-merge CI failure) #401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
637975e
fix(cef): raise STARTUP_GRACE_MS to 15s after a real post-merge CI fa…
qnbs Aug 19, 2026
1b3a933
docs(cef): correct STARTUP_GRACE_MS comment scope (CodeAnt finding)
qnbs Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion scripts/cef/run-launch-cycle-proof.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,17 @@ const cyclesArg = cyclesArgIdx !== -1 ? process.argv[cyclesArgIdx + 1] : undefin
const cycles = cyclesArgIdx === -1 ? 3 : Number(cyclesArg);

// QNBS-v3: raised from 4000ms after two consecutive CI runs on identical code (byte-for-byte matching main, which had passed reliably before) showed the browser process alive but never reaching OnAfterCreated within the old window — runner-speed variance, not a code regression.
const STARTUP_GRACE_MS = 10000;
// QNBS-v3: raised again from 10000ms after the same "Cycle 1: no FFI boundary proof" symptom
// recurred on a main push right after PR #400 added -g to worldscript_host — real, measured
// evidence: the binary grew from 1.34MB to 6.33MB (target_compile_options in
// apps/desktop-cef/CMakeLists.txt), a plausible contributor to slower first-launch I/O on a
// loaded runner. Cycles 2/3 in runCycle always passed at the old window — the actual observed
// failure only ever hit the cold first launch there. This constant is also read by
// runCrashReportingProofCycle's own renderer-crash-detection timeout below (line ~278) — a
// shared constant, not a runCycle-only one; that consumer's failure-detection window widens by
// the same 5s as a side effect, which is fine (strictly more lenient, same CI-runner-speed
// rationale applies), not a dedicated timeout since there's no evidence the two need to differ.
const STARTUP_GRACE_MS = 15000;
const SHUTDOWN_GRACE_MS = 6000;
// QNBS-v3: extra buffer after the main process exits — a renderer/GPU subprocess can take a moment longer to actually be reaped than its parent (docs/cef/knowledge/subprocess-and-shutdown.md's own "not instantaneous" finding applies to the whole tree, not just the browser process).
const ORPHAN_CHECK_GRACE_MS = 3000;
Expand Down
Loading